Cleaning up and testing get_directory_index
#483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
jamesbraza
force-pushed
the
better-index-logic
branch
from
5ed0a39
to
a5399aa
Compare
jamesbraza
commented
Sep 25, 2024
| @@ -343,7 +343,7 @@ async def maybe_get_manifest( | |||
| async with await anyio.open_file(filename, mode="r") as file: | |||
| content = await file.read() | |||
| records = [DocDetails(**row) for row in csv.DictReader(StringIO(content))] | |||
| logger.info( | |||
| logger.debug( | |||
There was a problem hiding this comment.
This was a bit noisy, so downgraded its level
mskarlin
reviewed
Sep 25, 2024
| paper_dir = cast(Path, agent_test_settings.paper_directory) | ||
| assert results[0].docs.keys() == {md5sum((paper_dir / "bates.txt").absolute())} | ||
| # Use a tempdir here so we can delete files without affecting concurrent tests | ||
| with tempfile.TemporaryDirectory() as tempdir: |
There was a problem hiding this comment.
I would have thought this fixture would handle that -- did you see deleting files affecting other tests?
There was a problem hiding this comment.
Yeah good question. I just expanded the explanatory comment to address this:
# Since agent_test_settings is used by other tests, and thus uses the same
# paper_directory as other tests, we use a tempdir so we can delete files
# without affecting concurrent tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this code somewhat confusing, so I: