Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaning up and testing get_directory_index #483

Merged
merged 5 commits into from
Sep 25, 2024
Merged

Cleaning up and testing get_directory_index #483

merged 5 commits into from
Sep 25, 2024

Commits on Sep 25, 2024

  1. Testing with custom index name

    @jamesbraza
    jamesbraza committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    96e18c9 View commit details
    Browse the repository at this point in the history

  2. Testing resume-ability of get_directory_index

    @jamesbraza
    jamesbraza committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    519aab8 View commit details
    Browse the repository at this point in the history

  3. Made variable names more intuitive, and added type hints

    @jamesbraza
    jamesbraza committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    a5399aa View commit details
    Browse the repository at this point in the history

  4. Converted maybe_get_manifest to debug log to avoid noisy logs

    @jamesbraza
    jamesbraza committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    f08d2f3 View commit details
    Browse the repository at this point in the history

  5. Expanded comment explaining why TemporaryDirectory in test_get_direct… 

    …ory_index
    @jamesbraza
    jamesbraza committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    808f569 View commit details
    Browse the repository at this point in the history