Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress bar for indexing #485

Closed
wants to merge 5 commits into from
Closed

Progress bar for indexing #485

wants to merge 5 commits into from

Conversation

jamesbraza
Copy link
Collaborator

This PR:

  • Decomposes agents.__init__ behaviors for readability and importability
  • Adds forgotten rich to mypy dependencies
  • Integrates progress bar for CLI or opt-in/out via env vars

@jamesbraza jamesbraza added the enhancement New feature or request label Sep 26, 2024
@jamesbraza jamesbraza self-assigned this Sep 26, 2024
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Sep 26, 2024
markup=True,
show_path=False,
show_level=False,
console=Console(force_terminal=True),
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Console was why rich's Progress wasn't playing nice earlier

Copy link
Collaborator

@whitead whitead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

╔════════════════════════════════════╗
║        ~~~ Progress Tracker ~~~    ║
╠════════════════════════════════════╣
║                                    ║
║   Winning: [████████▒▒▒▒▒▒▒▒▒▒] 60%║
║                                    ║
╚════════════════════════════════════╝

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 27, 2024
@jamesbraza
Copy link
Collaborator Author

Closing this for now as what happens at inference time is 5 million progress bars show up, one per paper_search. I made an issue to track this upstream issue #488

I will close for now in favor of that

@jamesbraza jamesbraza closed this Sep 27, 2024
@jamesbraza jamesbraza deleted the logging-progress branch September 27, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants