Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allowing parse_text to be given a str path #491

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Allowing parse_text to be given a str path #491

merged 1 commit into from
Sep 27, 2024

Conversation

jamesbraza
Copy link
Collaborator

Closes #490

@jamesbraza jamesbraza added the enhancement New feature or request label Sep 27, 2024
@jamesbraza jamesbraza self-assigned this Sep 27, 2024
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Sep 27, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 27, 2024
@jamesbraza jamesbraza merged commit f2d8c6e into main Sep 27, 2024
3 of 5 checks passed
@jamesbraza jamesbraza deleted the allowing-str-parse branch September 27, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whitead whitead whitead approved these changes

@mskarlin mskarlin Awaiting requested review from mskarlin

@nadolskit nadolskit Awaiting requested review from nadolskit

Assignees

@jamesbraza jamesbraza

Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

path.open AttributeError：str object has no attribute 'open'
2 participants
@jamesbraza @whitead