Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an after model validator ensuring temp=1 for o1 models #649

Merged
merged 8 commits into from
Oct 29, 2024
Merged

Add an after model validator ensuring temp=1 for o1 models #649

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
10cd1f8
Improve message to include the passed temperature per review comment
dakoner Oct 28, 2024
9b4adf0
Check model using prefix o1- instead of exact match.
dakoner Oct 28, 2024
8dfba51
Add more description model name to error message.
dakoner Oct 28, 2024
f8a0213
Add an after model validator ensuring temp=1 for o1 models
dakoner Oct 29, 2024
df586b6
Add fix from pre-commit
dakoner Oct 28, 2024
c4f194b
Add test that verifies o1 temperature=1 model validation
dakoner Oct 29, 2024
95e95b7
pylint/pre-commit fixes
dakoner Oct 29, 2024
03b2a68
Merge branch 'main' into o1-preview-temperature-validation
dakoner Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions paperqa/settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -678,6 +678,19 @@ def _deprecated_field(self) -> Self:
setattr(self.agent.index, new_name, value) # Propagate to new location
return self

@model_validator(mode="after")
def _validate_temperature_for_o1_preview(self) -> Self:
dakoner marked this conversation as resolved.
Show resolved Hide resolved
"""Ensures temperature is 1 if the LLM is 'o1-preview' or 'o1-mini'.

o1 reasoning models only support temperature = 1. See
https://platform.openai.com/docs/guides/reasoning/quickstart
"""
if self.llm in ("o1-preview", "o1-mini") and self.temperature != 1:
dakoner marked this conversation as resolved.
Show resolved Hide resolved
raise ValueError(
"When using 'o1-preview' LLM, the temperature must be set to 1."
dakoner marked this conversation as resolved.
Show resolved Hide resolved
)
return self

@computed_field # type: ignore[prop-decorator]
@property
def md5(self) -> str:
Expand Down
Loading