Fixing flaky tests test_code and test_minimal_fields_filtering
#652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
dakoner
reviewed
Oct 29, 2024
| def test_code() -> None: | ||
| # load this script | ||
| doc_path = Path(os.path.abspath(__file__)) |
There was a problem hiding this comment.
Side comment: why did you include these changes to the doc path (moving the directory the doc to THIS_MODULE. Does it actually change functionality or is it a cleanup?
There was a problem hiding this comment.
It was cleanup, mainly I noticed usage of both os.path and pathlib.Path in the same line and smh'd
dakoner
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_codefailed with"I cannot answer.", so this PR adds retrying for thattest_minimal_fields_filtering#651, it showed thetest_minimal_fields_filteringis flaky, so this PR beefs up its assertion