Removed gen_answer
's dead argument question
#689
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
gen_answer
tool has an unusedquestion
arg. This PR removes it.I observed for the LitQA2 question:
The agent called
gen_answer
with thequestion
arg:Whereas this is mostly the same question, it has a few problems:
gen_answer
usestate.session.question
, not the inputquestion
, so the logs were inaccurategen_answer
with different inputquestion
s, when actually nothing different happens