Merge pull request #42 from G-Core/ref/stats_interface

refactor: drop async from write_stats method
G-Core · Oct 16, 2024 · 0c396ff · 0c396ff
2 parents 92e91aa + 07d59c8
commit 0c396ff
Show file tree

Hide file tree

Showing 6 changed files with 20 additions and 37 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/crates/http-service/Cargo.toml b/crates/http-service/Cargo.toml
@@ -32,7 +32,7 @@ futures = "0.3.30"
 once_cell = "1.19"
 prometheus = { version = "0.13.3", features = ["process"], optional = true }
 serde = "1.0"
-clickhouse = { version = "0.12.0", optional = true }
+clickhouse = { version = "0.13", optional = true }
 chrono = "0.4"
 async-trait = "0.1"
 wasmtime-wasi-http = "20.0.2"

diff --git a/crates/http-service/src/lib.rs b/crates/http-service/src/lib.rs
@@ -302,7 +302,7 @@ where
                         request_id: request_id.to_string(),
                         ..Default::default()
                     };
-                    self.context.write_stats(stat_row).await;
+                    self.context.write_stats(stat_row);
                 }
                 #[cfg(feature = "metrics")]
                 metrics::metrics(
@@ -407,7 +407,7 @@ where
                         request_id: request_id.to_string(),
                         ..Default::default()
                     };
-                    self.context.write_stats(stat_row).await;
+                    self.context.write_stats(stat_row);
                 }
                 #[cfg(not(feature = "stats"))]
                 tracing::debug!(?fail_reason, request_id, "stats");
@@ -637,7 +637,7 @@ mod tests {
     }
 
     impl StatsWriter for TestContext {
-        async fn write_stats(&self, _stat: StatRow) {}
+        fn write_stats(&self, _stat: StatRow) {}
     }
 
     impl Router for TestContext {

diff --git a/crates/runtime/Cargo.toml b/crates/runtime/Cargo.toml
@@ -34,7 +34,7 @@ serde = "1.0"
 serde_json = "1.0.108"
 chrono = { version = "0.4", features = ["serde"] }
 prometheus = { version = "0.13.3", features = ["process"], optional = true }
-clickhouse = { version = "0.12.0", optional = true }
+clickhouse = { version = "0.13", optional = true }
 lazy_static = { version = "1.4.0", optional = true }
 wasmtime-wasi-http = "20.0.2"
 

diff --git a/crates/runtime/src/util/stats.rs b/crates/runtime/src/util/stats.rs
@@ -24,5 +24,5 @@ pub struct StatRow {
 pub struct StatRow;
 
 pub trait StatsWriter {
-    fn write_stats(&self, stat: StatRow) -> impl std::future::Future<Output = ()> + Send;
+    fn write_stats(&self, stat: StatRow);
 }
diff --git a/src/main.rs b/src/main.rs
@@ -300,7 +300,7 @@ impl Router for CliContext {
 }
 
 impl StatsWriter for CliContext {
-    async fn write_stats(&self, _stat: StatRow) {}
+    fn write_stats(&self, _stat: StatRow) {}
 }
 
 fn parse_key_value<T, U>(