diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index a236ebc..5f9d3cd 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -47,37 +47,37 @@ jobs: with: token: ${{ secrets.GITHUB_TOKEN }} - coverage: - needs: build - runs-on: ubuntu-latest - if: github.ref != 'refs/heads/main' - steps: - - name: Clone repo - uses: actions/checkout@v4 - with: - submodules: recursive - - - uses: actions-rs/toolchain@v1 - with: - toolchain: nightly - override: true - - - uses: actions-rs/cargo@v1 - name: Run test with code coverage report - with: - command: test - args: --workspace --all-features --no-fail-fast - env: - CARGO_INCREMENTAL: '0' - RUSTFLAGS: '-Zprofile -Ccodegen-units=1 -Cinline-threshold=0 -Clink-dead-code -Coverflow-checks=off -Cpanic=abort -Zpanic_abort_tests' - RUSTDOCFLAGS: '-Zprofile -Ccodegen-units=1 -Cinline-threshold=0 -Clink-dead-code -Coverflow-checks=off -Cpanic=abort -Zpanic_abort_tests' - - - id: coverage - name: Collect code coverage - uses: actions-rs/grcov@v0.1 - - - name: Archive code coverage results - uses: actions/upload-artifact@v4 - with: - name: code-coverage-report - path: ${{ steps.coverage.outputs.report }} \ No newline at end of file +# coverage: +# needs: build +# runs-on: ubuntu-latest +# if: github.ref != 'refs/heads/main' +# steps: +# - name: Clone repo +# uses: actions/checkout@v4 +# with: +# submodules: recursive +# +# - uses: actions-rs/toolchain@v1 +# with: +# toolchain: nightly +# override: true +# +# - uses: actions-rs/cargo@v1 +# name: Run test with code coverage report +# with: +# command: test +# args: --workspace --all-features --no-fail-fast +# env: +# CARGO_INCREMENTAL: '0' +# RUSTFLAGS: '-Zprofile -Ccodegen-units=1 -Cinline-threshold=0 -Clink-dead-code -Coverflow-checks=off -Cpanic=abort -Zpanic_abort_tests' +# RUSTDOCFLAGS: '-Zprofile -Ccodegen-units=1 -Cinline-threshold=0 -Clink-dead-code -Coverflow-checks=off -Cpanic=abort -Zpanic_abort_tests' +# +# - id: coverage +# name: Collect code coverage +# uses: actions-rs/grcov@v0.1 +# +# - name: Archive code coverage results +# uses: actions/upload-artifact@v4 +# with: +# name: code-coverage-report +# path: ${{ steps.coverage.outputs.report }} \ No newline at end of file diff --git a/Cargo.toml b/Cargo.toml index 7f794b2..2e72484 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -3,7 +3,7 @@ members = ["crates/*"] resolver = "2" [workspace.package] -version = "0.3.8" +version = "0.3.9" edition = "2021" publish = false authors = ["FastEdge Development Team"] diff --git a/crates/http-service/src/lib.rs b/crates/http-service/src/lib.rs index 645d73a..2442375 100644 --- a/crates/http-service/src/lib.rs +++ b/crates/http-service/src/lib.rs @@ -234,7 +234,7 @@ where app_name, request.uri() ); - let cfg = match self.context.lookup(&app_name).await { + let cfg = match self.context.lookup_by_name(&app_name).await { None => { #[cfg(feature = "metrics")] metrics::metrics(AppResult::UNKNOWN); @@ -612,7 +612,7 @@ mod tests { } impl Router for TestContext { - async fn lookup(&self, _name: &str) -> Option { + async fn lookup_by_name(&self, _name: &str) -> Option { self.app.clone() } } diff --git a/crates/runtime/src/lib.rs b/crates/runtime/src/lib.rs index 020ad5a..a131bf4 100644 --- a/crates/runtime/src/lib.rs +++ b/crates/runtime/src/lib.rs @@ -314,7 +314,8 @@ pub trait ExecutorCache { } pub trait Router: Send + Sync { - fn lookup(&self, name: &str) -> impl std::future::Future> + Send; + fn lookup_by_name(&self, name: &str) -> impl std::future::Future> + Send; + fn lookup_by_id(&self, id: u64) -> impl std::future::Future> + Send; } pub fn componentize_if_necessary(buffer: &[u8]) -> anyhow::Result> { diff --git a/src/main.rs b/src/main.rs index d05368a..316839b 100644 --- a/src/main.rs +++ b/src/main.rs @@ -246,9 +246,13 @@ impl ContextHeaders for CliContext<'_> { } impl Router for CliContext<'_> { - async fn lookup(&self, _name: &str) -> Option { + async fn lookup_by_name(&self, _name: &str) -> Option { self.app.to_owned() } + + async fn lookup_by_id(&self, _id: u64) -> Option { + unreachable!() + } } impl StatsWriter for CliContext<'_> {