-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log from/to time parse and app by name #23
Conversation
This PR now includes updating all FastEdge commands to use app name instead of app id. |
internal/commands/fastedge/app.go
Outdated
if err != nil { | ||
return fmt.Errorf("parsing app id: %w", err) | ||
return fmt.Errorf("getting app id: %w", err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it is CLI that directly communicates with user it would be nice to show more human-readable error messages, such as "Cannot find app by name: ...". I know our guidelines require certain format for errors, but it is more about writing to the logs, but for the user we need to show something more understandable.
We need to keep it in mind with CLI, I know I'm also guilty of writing unfriendly error messages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, pushing change.
Merge after github.com/G-Core/FastEdge-client-sdk-go is updated.