Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log from/to time parse and app by name #23

Merged
merged 6 commits into from
Mar 19, 2024

Conversation

KenanHH
Copy link
Collaborator

@KenanHH KenanHH commented Feb 21, 2024

@KenanHH KenanHH marked this pull request as ready for review February 28, 2024 20:07
@KenanHH KenanHH mentioned this pull request Feb 28, 2024
@KenanHH KenanHH requested a review from qrdl March 10, 2024 21:27
@KenanHH
Copy link
Collaborator Author

KenanHH commented Mar 10, 2024

This PR now includes updating all FastEdge commands to use app name instead of app id.

if err != nil {
return fmt.Errorf("parsing app id: %w", err)
return fmt.Errorf("getting app id: %w", err)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it is CLI that directly communicates with user it would be nice to show more human-readable error messages, such as "Cannot find app by name: ...". I know our guidelines require certain format for errors, but it is more about writing to the logs, but for the user we need to show something more understandable.
We need to keep it in mind with CLI, I know I'm also guilty of writing unfriendly error messages

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, pushing change.

@KenanHH KenanHH merged commit b6ef3c5 into main Mar 19, 2024
4 checks passed
@KenanHH KenanHH deleted the improving-time-parse-and-logs-by-app-name branch March 19, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants