Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCLOUD2-14662 Add missing timeouts to create pool opts #130

Merged
merged 1 commit into from
Jul 2, 2024
Merged

GCLOUD2-14662 Add missing timeouts to create pool opts #130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions gcore/loadbalancer/v1/loadbalancers/requests.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ type CreateHealthMonitorOpts struct {
MaxRetriesDown int `json:"max_retries_down,omitempty"`
HTTPMethod *types.HTTPMethod `json:"http_method,omitempty"`
URLPath string `json:"url_path,omitempty"`
ExpectedCodes string `json:"expected_codes,omitempty"`
}

// CreatePoolMemberOpts represents options used to create a loadbalancer listener pool member.
Expand All @@ -138,6 +139,9 @@ type CreatePoolOpts struct {
HealthMonitor *CreateHealthMonitorOpts `json:"healthmonitor,omitempty"`
LoadBalancerAlgorithm types.LoadBalancerAlgorithm `json:"lb_algorithm,omitempty"`
SessionPersistence *CreateSessionPersistenceOpts `json:"session_persistence,omitempty"`
TimeoutClientData *int `json:"timeout_client_data,omitempty"`
TimeoutMemberData *int `json:"timeout_member_data,omitempty"`
TimeoutMemberConnect *int `json:"timeout_member_connect,omitempty"`
}

// CreateListenerOpts represents options used to create a loadbalancer listener.
Expand Down
4 changes: 2 additions & 2 deletions gcore/region/v1/regions/testing/fixtures.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,10 +99,10 @@ var (
TaskID: nil,
EndpointType: types.EndpointTypePublic,
ExternalNetworkID: "0521f854-8e34-4e67-8827-2aeb27fb3872",
SpiceProxyURL: *spiceURL,
SpiceProxyURL: spiceURL,
CreatedOn: createdTime,
KeystoneID: 1,
Keystone: keystones.Keystone{
Keystone: &keystones.Keystone{
ID: 1,
URL: *keystoneURL,
State: keystonetypes.KeystoneStateNew,
Expand Down
Loading