Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hook up the Diamond, DiamondLoupeFacet, OwnershipFacet CLIs to "game7ctl" #20

Open
zomglings opened this issue Jan 17, 2023 · 0 comments · Fixed by #21
Open

Hook up the Diamond, DiamondLoupeFacet, OwnershipFacet CLIs to "game7ctl" #20

zomglings opened this issue Jan 17, 2023 · 0 comments · Fixed by #21
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@zomglings
Copy link
Collaborator

Currently, if you want to use those CLIs, you have to call them as:

python -m game7ctl.DiamondLoupeFacet verify-contract -h

These should be accessible directly from the game7ctl invocation as:

game7ctl diamond-loupe verify-contract -h
@zomglings zomglings added enhancement New feature or request good first issue Good for newcomers labels Jan 17, 2023
@muddi900 muddi900 mentioned this issue Jan 18, 2023
Merged
muddi900 added a commit to muddi900/contracts that referenced this issue Jan 23, 2023
@muddi900
Added Dimonds and Ownership to cli and refactored subparser[Issue G7D…
d67b8ee 
…AO#20]

Added better type hints.

black reformating

bumped the version number
zomglings added a commit that referenced this issue Jan 30, 2023
@zomglings
Merge pull request #21 from muddi900/add/chmod
015c561 
Added Dimonds and Ownership to cli and refactored subparser[Issue #20]
@ogarciarevett ogarciarevett mentioned this issue Jan 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added Dimonds and Ownership to cli and refactored subparser[Issue #20] muddi900/contracts
1 participant
@zomglings