Added Dimonds and Ownership to cli and refactored subparser[Issue #20] #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zomglings
reviewed
Jan 18, 2023
game7ctl/game7ctl/cli.py
Outdated
| from .version import VERSION | ||
|
|
||
|
|
||
| def add_subparser(cmd_name: str, subparser, cli_gen: callable): |
There was a problem hiding this comment.
@muddi900 : Seems like an unnecesary abstraction - you aren't really saving anything with this add_subparser function.
But if you do want to keep it, I don't have a super strong opinion.
I would suggest:
subparsershould have type annotation:argparse.ArgumentParser- Fix type annotation on
cli_genusingtyping.Callable- https://mypy.readthedocs.io/en/stable/kinds_of_types.html#callable-types-and-lambdas
|
@muddi900 : Looks ok to me, could you please bump the version to 0.0.2? |
|
@muddi900 : Could you merge |
…AO#20] Added better type hints. black reformating bumped the version number
|
The branch is rebased, the code is reformatted and the version number is bumped. |
ogarciarevett
requested changes
Jan 28, 2023
zomglings
approved these changes
Jan 30, 2023
There was a problem hiding this comment.
lgtm
@ogarciarevett : I changed target branch to develop myself. Merging now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20