Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define the "slot type" #8

Open
ogarciarevett opened this issue Jan 9, 2023 · 3 comments
Open

Define the "slot type" #8

ogarciarevett opened this issue Jan 9, 2023 · 3 comments
Assignees

Comments

@ogarciarevett
Copy link
Contributor

ogarciarevett commented Jan 9, 2023

Define the type of slot:

Example:

If we have "accessories" in the inventory, how many rings could I have "active" ?

This should be an Argument for the Diamond init ?
To be more reusable?
How many "slots" will be "double" renderable in the UI? Only the "boots", "shoulders", and "hands"? What about "wings"?
We will have wings?

@ogarciarevett ogarciarevett self-assigned this Jan 9, 2023
@ogarciarevett ogarciarevett converted this from a draft issue Jan 9, 2023
@ogarciarevett ogarciarevett moved this from Todo to In Progress in NFT Inventory system Jan 9, 2023
@ogarciarevett ogarciarevett changed the title Define the "slot type" for each "achievement" Define the "slot type" Jan 9, 2023
@ogarciarevett
Copy link
Contributor Author

ogarciarevett commented Jan 10, 2023

As a result of this "spike" we have these slot types:

  1. Equippable NFTs(Already in the PR, ERC20, ERC721, ERC1155)
  2. Materials NFTs(Unequippable NFT, could be in the PR as a "0" value but actually will be better if we create a new type, I'll add this to part 2 of the Inventory)
  3. Trophy NFTs(is actually just a badge but is crafted, I don't really know if we need to put it as a different type for the smart contract side, but the UI will need this for sure)

@zomglings
Copy link
Collaborator

I don't think these should be stored on-chain. This should be part of the slot metadata. We do need to support slotUri on-chain, but I would hesitate to implement much more than that.

@ogarciarevett
Copy link
Contributor Author

@zomglings I agree but not in all, we don't need to define the entire metadata but at least the type as an Enum with the slotUri could be useful for any inventory. If we do this off-chain we're always requiring that the slot type must be stored and a UI app can't use this without a backend for example.

So, giving a slot_type has an optional argument to the slot has better reusability purposes. It's optional.

I'll close the issue with this, but if anyone has different thoughts on this, just left a comment over here 👇

Or any new idea is also valid 😄

@github-project-automation github-project-automation bot moved this from In Progress to Done in NFT Inventory system Jan 12, 2023
@ogarciarevett ogarciarevett reopened this Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants