Feature/add verify contract to cli #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zomglings
reviewed
Feb 1, 2023
There was a problem hiding this comment.
@ogarciarevett : Left some suggestions.
It seems like this depends on #22 ? Going to review that now.
…he slotType creation + add the slot type in the createSlot() event
zomglings
force-pushed
the
feature/add-verify-contract-to-cli
branch
from
7a81501
to
e729f5a
Compare
…-verify-contract-to-cli
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
--verify-contractsto the cli. #20You can test it like:
WARNING: If you active the
--verify-contracsthe deployment time increase dramatically. Remember that this uploads the ABI in the network and waits for that specific network verification. So, it's a time variable that We can't modify or improve.