Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Block iframe embeds #12470

Open
2 tasks
esizer opened this issue Jan 10, 2025 · 1 comment
Open
2 tasks

♻️ Block iframe embeds #12470

esizer opened this issue Jan 10, 2025 · 1 comment
Labels
debt Refactor or improve existing code. security Related to app security.

Comments

@esizer
Copy link
Member

esizer commented Jan 10, 2025

♻️ Debt/Refactor

We currently do not have a policy header for frames and should add one.

🕵️ Details

I do not think we use iframes anywhere on the site so we should probably just block them outright?

🙋‍♀️ Proposed Solution

Add the following headers (one we have and you just need to append to the CSP).

Content-Security-Policy: frame-ancestors 'none'
X-Frame-Options: DENY

✅ Acceptance Criteria

  • Frame ancestors set to none in our CSP
  • X-Frame-Options header set to DENY
@esizer esizer added the debt Refactor or improve existing code. label Jan 10, 2025
@esizer esizer added the security Related to app security. label Jan 10, 2025
@mnigh mnigh added the review in refinement Ready to be looked at and pulled into "ready to dev" label Jan 13, 2025
@tristan-orourke
Copy link
Member

We need to check if our logout process uses an iframe.
If it does, we can add it to a whitelist.

@tristan-orourke tristan-orourke removed the review in refinement Ready to be looked at and pulled into "ready to dev" label Jan 13, 2025
@tristan-orourke tristan-orourke moved this to 🏭 Ready for Estimate in GC Digital Talent Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Refactor or improve existing code. security Related to app security.
Projects
Status: 🏭 Ready for Estimate
Development

No branches or pull requests

3 participants