-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feedback on the Proposed Design #2
Comments
Hello @allendav
This is a question on naming, and even throug naming is very important, this is an issue there can be taken care of later on, since a lot of people have an opinion about naming, and for our point of view, we focus on the functionality,
it is correct we send a $GdprToolbox object to the plugins developers. - when we use an action. A new instance of the toolbox will be created for each plugin.
The code will be commented, but for now, the focus is to make a code that works, (and smaller comments to note what the functions does) and then we will create better documentation. GDPRWP/GDPRWP-Plugin-Sample
The plan is, that we have a settings page, where the data is presented for the admin, and the data is loaded using ajax. - The data of the fields, may also be processed using a callback (@todo)
an example is the "woocommerce_checkout_create_order_line_item" action. I know it is not 100% the same, but i see many similarities.
We have adapted some of this. - so instead of running on different hooks, we run on a init. |
The intention is to make an Open Source plugin available on the Repo. Hopefully, that will be implemented into core - in some capacity or other. It's NOT a product of Peytz & Co. That said, we will, of course, be offering add-on plugins to add pro features when we see a need - but anybody can do that on the basis of this. |
First, thank you @dejliglama for pulling this together. I appreciate it is not easy to tackle such an audacious task as this. I have some concerns about this design that I'll do my best to communicate below, along with a proposed alternate design.
FWIW, to help inform my feedback, I wrote a simple plugin that handles sensitive user-identifying data here and then looked at your design to imagine how I would go about hooking it in.
I have included feedback here for both this repo and the GDPRWP-Plugin-Sample repo:
GDPRWP/GDPRWP-Plugin
GDPRWP/GDPRWP-Plugin-Sample
and then inside a plugin, that plugin’s user-data processing object(s) could register by something like this:
That way, after all the plugins have registered all their user-data processors in init, we could safely in a later hook do whatever we need to do, whether it is assembling user data for export, redacting user data from the database, or building a privacy policy using snippets provided by plugins.
I appreciate this is a radical departure from your proposed design. What do you think?
The text was updated successfully, but these errors were encountered: