fix: 마지막 코드리뷰

GDSC-Hongik · Jun 7, 2024 · c0109bd · c0109bd
1 parent a516c35
commit c0109bd
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/packages/wow-ui/src/components/Chip/Chip.stories.ts b/packages/wow-ui/src/components/Chip/Chip.stories.ts
@@ -103,7 +103,7 @@ type Story = StoryObj<typeof meta>;
 export const Default: Story = {
   args: {
     label: "Chip",
-    element: "button",
+    as: "button",
     clickable: true,
   },
 };
@@ -112,15 +112,15 @@ export const DivChip: Story = {
   args: {
     label: "Chip",
     clickable: false,
-    element: "div",
+    as: "div",
   },
 };
 export const DisabledChip: Story = {
   args: {
     label: "Chip",
     clickable: true,
     disabled: true,
-    element: "button",
+    as: "button",
   },
 };
 

diff --git a/packages/wow-ui/src/components/Chip/index.tsx b/packages/wow-ui/src/components/Chip/index.tsx
@@ -5,6 +5,7 @@ import type { ReactNode } from "react";
 import { forwardRef, useEffect, useState } from "react";
 
 import type {
+  AsProps,
   ButtonElementType,
   PolymorphicComponentProps,
   PolymorphicRef,

diff --git a/packages/wow-ui/src/types/button.ts b/packages/wow-ui/src/types/button.ts
@@ -5,7 +5,6 @@ export type ButtonElementType = Extract<ElementType, "button" | "div" | "span">;
 // 버튼의 주요한 HTML Attributes를 미리 정의한 ButtonProps 타입입니다. [https://www.w3schools.com/tags/tag_button.asp]
 
 export interface BasicButtonProps {
-  element?: ButtonElementType;
   /**
    * 버튼의 ID를 지정합니다.
    */