BATM-6033 Improve IDepositX API to return similar data as ITransactio…

…nX interfaces
GENERALBYTESCOM · May 31, 2024 · 61030bc · 61030bc
1 parent f25a19f
commit 61030bc
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 12 deletions.
diff --git a/...extensions_api/src/main/java/com/generalbytes/batm/server/extensions/IDepositDetails.java b/...extensions_api/src/main/java/com/generalbytes/batm/server/extensions/IDepositDetails.java
@@ -39,9 +39,9 @@ public interface IDepositDetails {
     String getDepositCode();
 
     /**
-     * Identity of the customer who made the deposit.
+     * Identity public ID of the customer who made the deposit.
      */
-    IIdentity getIdentity();
+    String getIdentityPublicId();
 
     /**
      * Amount of cash deposited.
@@ -63,8 +63,4 @@ public interface IDepositDetails {
      */
     String getLocalTransactionId();
 
-    /**
-     * List of banknotes deposited in the transaction.
-     */
-    List<IBanknoteCounts> getBanknotes();
 }
diff --git a/...nsions_api/src/main/java/com/generalbytes/batm/server/extensions/IDepositPreparation.java b/...nsions_api/src/main/java/com/generalbytes/batm/server/extensions/IDepositPreparation.java
@@ -51,9 +51,9 @@ public interface IDepositPreparation {
     String getCashCurrency();
 
     /**
-     * Identity of the customer who made the deposit.
+     * Identity public ID of the customer who made the deposit.
      */
-    IIdentity getIdentity();
+    String getIdentityPublicId();
 
     /**
      * Error message in case of error.

diff --git a/...extensions_api/src/main/java/com/generalbytes/batm/server/extensions/IDepositRequest.java b/...extensions_api/src/main/java/com/generalbytes/batm/server/extensions/IDepositRequest.java
@@ -55,9 +55,9 @@ public interface IDepositRequest {
     String getCashCurrency();
 
     /**
-     * Identity of the customer who made the deposit.
+     * Identity public ID of the customer who made the deposit.
      */
-    IIdentity getIdentity();
+    String getIdentityPublicId();
 
     /**
      * Error message in case of error.

diff --git a/...sions_api/src/main/java/com/generalbytes/batm/server/extensions/ITransactionListener.java b/...sions_api/src/main/java/com/generalbytes/batm/server/extensions/ITransactionListener.java
@@ -151,7 +151,7 @@ default IDepositPreparation overrideDepositPreparation(IDepositPreparation prepa
      *
      * @return result of the approval
      */
-    default boolean isTransactionApproved(IDepositRequest depositRequest) {
+    default boolean isDepositApproved(IDepositRequest request) {
         return true;
     }
 
@@ -166,7 +166,7 @@ default boolean isTransactionApproved(IDepositRequest depositRequest) {
      * @param request The transaction request initialized by server
      * @return {@link ITransactionRequest} that may contain modified transaction request.
      */
-    default IDepositRequest overrideTransactionRequest(IDepositRequest request) {
+    default IDepositRequest overrideDepositRequest(IDepositRequest request) {
         return request;
     }