From 61030bc13a15f04cd482466279f9d1f61108553c Mon Sep 17 00:00:00 2001
From: Filip Ocelka <filip.ocelka@generalbytes.com>
Date: Fri, 31 May 2024 16:17:53 +0200
Subject: [PATCH] BATM-6033 Improve IDepositX API to return similar data as
 ITransactionX interfaces

---
 .../batm/server/extensions/IDepositDetails.java           | 8 ++------
 .../batm/server/extensions/IDepositPreparation.java       | 4 ++--
 .../batm/server/extensions/IDepositRequest.java           | 4 ++--
 .../batm/server/extensions/ITransactionListener.java      | 4 ++--
 4 files changed, 8 insertions(+), 12 deletions(-)

diff --git a/server_extensions_api/src/main/java/com/generalbytes/batm/server/extensions/IDepositDetails.java b/server_extensions_api/src/main/java/com/generalbytes/batm/server/extensions/IDepositDetails.java
index a2f1957a9..f135e700e 100644
--- a/server_extensions_api/src/main/java/com/generalbytes/batm/server/extensions/IDepositDetails.java
+++ b/server_extensions_api/src/main/java/com/generalbytes/batm/server/extensions/IDepositDetails.java
@@ -39,9 +39,9 @@ public interface IDepositDetails {
     String getDepositCode();
 
     /**
-     * Identity of the customer who made the deposit.
+     * Identity public ID of the customer who made the deposit.
      */
-    IIdentity getIdentity();
+    String getIdentityPublicId();
 
     /**
      * Amount of cash deposited.
@@ -63,8 +63,4 @@ public interface IDepositDetails {
      */
     String getLocalTransactionId();
 
-    /**
-     * List of banknotes deposited in the transaction.
-     */
-    List<IBanknoteCounts> getBanknotes();
 }
diff --git a/server_extensions_api/src/main/java/com/generalbytes/batm/server/extensions/IDepositPreparation.java b/server_extensions_api/src/main/java/com/generalbytes/batm/server/extensions/IDepositPreparation.java
index b333ee6ab..f5b593f69 100644
--- a/server_extensions_api/src/main/java/com/generalbytes/batm/server/extensions/IDepositPreparation.java
+++ b/server_extensions_api/src/main/java/com/generalbytes/batm/server/extensions/IDepositPreparation.java
@@ -51,9 +51,9 @@ public interface IDepositPreparation {
     String getCashCurrency();
 
     /**
-     * Identity of the customer who made the deposit.
+     * Identity public ID of the customer who made the deposit.
      */
-    IIdentity getIdentity();
+    String getIdentityPublicId();
 
     /**
      * Error message in case of error.
diff --git a/server_extensions_api/src/main/java/com/generalbytes/batm/server/extensions/IDepositRequest.java b/server_extensions_api/src/main/java/com/generalbytes/batm/server/extensions/IDepositRequest.java
index b6da2a508..96bd705c7 100644
--- a/server_extensions_api/src/main/java/com/generalbytes/batm/server/extensions/IDepositRequest.java
+++ b/server_extensions_api/src/main/java/com/generalbytes/batm/server/extensions/IDepositRequest.java
@@ -55,9 +55,9 @@ public interface IDepositRequest {
     String getCashCurrency();
 
     /**
-     * Identity of the customer who made the deposit.
+     * Identity public ID of the customer who made the deposit.
      */
-    IIdentity getIdentity();
+    String getIdentityPublicId();
 
     /**
      * Error message in case of error.
diff --git a/server_extensions_api/src/main/java/com/generalbytes/batm/server/extensions/ITransactionListener.java b/server_extensions_api/src/main/java/com/generalbytes/batm/server/extensions/ITransactionListener.java
index f6c776d99..093589934 100644
--- a/server_extensions_api/src/main/java/com/generalbytes/batm/server/extensions/ITransactionListener.java
+++ b/server_extensions_api/src/main/java/com/generalbytes/batm/server/extensions/ITransactionListener.java
@@ -151,7 +151,7 @@ default IDepositPreparation overrideDepositPreparation(IDepositPreparation prepa
      *
      * @return result of the approval
      */
-    default boolean isTransactionApproved(IDepositRequest depositRequest) {
+    default boolean isDepositApproved(IDepositRequest request) {
         return true;
     }
 
@@ -166,7 +166,7 @@ default boolean isTransactionApproved(IDepositRequest depositRequest) {
      * @param request The transaction request initialized by server
      * @return {@link ITransactionRequest} that may contain modified transaction request.
      */
-    default IDepositRequest overrideTransactionRequest(IDepositRequest request) {
+    default IDepositRequest overrideDepositRequest(IDepositRequest request) {
         return request;
     }