BATM-6033 Improve IDepositX API to return similar data as ITransactionX interfaces #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drocek
reviewed
May 31, 2024
| @@ -166,7 +166,7 @@ default boolean isTransactionApproved(IDepositRequest depositRequest) { | |||
| * @param request The transaction request initialized by server | |||
| * @return {@link ITransactionRequest} that may contain modified transaction request. | |||
| */ | |||
| default IDepositRequest overrideTransactionRequest(IDepositRequest request) { | |||
| default IDepositRequest overrideDepositRequest(IDepositRequest request) { | |||
There was a problem hiding this comment.
For consistency, I would name the parameter as depositRequest. Or just request in the isDepositApproved method.
drocek
approved these changes
May 31, 2024
filipocelka
force-pushed
the
feature/BATM-6033-deposit-api
branch
from
29cdb34
to
61030bc
Compare
drocek
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nX interfaces