Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BATM-6033 Improve IDepositX API to return similar data as ITransactionX interfaces #914

Merged
merged 1 commit into from
Jun 3, 2024
Merged

BATM-6033 Improve IDepositX API to return similar data as ITransactionX interfaces #914

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions ...extensions_api/src/main/java/com/generalbytes/batm/server/extensions/IDepositDetails.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,9 @@ public interface IDepositDetails {
String getDepositCode();

/**
* Identity of the customer who made the deposit.
* Identity public ID of the customer who made the deposit.
*/
IIdentity getIdentity();
String getIdentityPublicId();

/**
* Amount of cash deposited.
Expand All @@ -63,8 +63,4 @@ public interface IDepositDetails {
*/
String getLocalTransactionId();

/**
* List of banknotes deposited in the transaction.
*/
List<IBanknoteCounts> getBanknotes();
}
4 changes: 2 additions & 2 deletions ...nsions_api/src/main/java/com/generalbytes/batm/server/extensions/IDepositPreparation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,9 @@ public interface IDepositPreparation {
String getCashCurrency();

/**
* Identity of the customer who made the deposit.
* Identity public ID of the customer who made the deposit.
*/
IIdentity getIdentity();
String getIdentityPublicId();

/**
* Error message in case of error.
Expand Down
4 changes: 2 additions & 2 deletions ...extensions_api/src/main/java/com/generalbytes/batm/server/extensions/IDepositRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,9 @@ public interface IDepositRequest {
String getCashCurrency();

/**
* Identity of the customer who made the deposit.
* Identity public ID of the customer who made the deposit.
*/
IIdentity getIdentity();
String getIdentityPublicId();

/**
* Error message in case of error.
Expand Down
4 changes: 2 additions & 2 deletions ...sions_api/src/main/java/com/generalbytes/batm/server/extensions/ITransactionListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ default IDepositPreparation overrideDepositPreparation(IDepositPreparation prepa
*
* @return result of the approval
*/
default boolean isTransactionApproved(IDepositRequest depositRequest) {
default boolean isDepositApproved(IDepositRequest request) {
return true;
}

Expand All @@ -166,7 +166,7 @@ default boolean isTransactionApproved(IDepositRequest depositRequest) {
* @param request The transaction request initialized by server
* @return {@link ITransactionRequest} that may contain modified transaction request.
*/
default IDepositRequest overrideTransactionRequest(IDepositRequest request) {
default IDepositRequest overrideDepositRequest(IDepositRequest request) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency, I would name the parameter as depositRequest. Or just request in the isDepositApproved method.

return request;
}

Expand Down
Loading