Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Electron Velocity Changes #331

Open
wants to merge 90 commits into
base: master
Choose a base branch
from

Conversation

bear-is-asleep
Copy link

No description provided.

@mroda88 mroda88 self-requested a review September 26, 2023 21:05
@mroda88 mroda88 added framework Framework related issues or improvements modelling Issues with any aspect of physics modelling labels Sep 26, 2023
Copy link
Member

@mroda88 mroda88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Starting to make comments. Here are a few initial

config/BardinIMDRadCorPXSec.xml Outdated Show resolved Hide resolved
config/IMDAnnihilationPXSec.xml Outdated Show resolved Hide resolved
config/PXSecOnElectron.xml Outdated Show resolved Hide resolved
config/StaticElectronVelocity.xml Outdated Show resolved Hide resolved
config/XSecOnElectron.xml Outdated Show resolved Hide resolved
Copy link
Member

@mroda88 mroda88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the changes are technical. There is one issue with the threshold though.

src/Physics/NuElectron/EventGen/NuEKinematicsGenerator.cxx Outdated Show resolved Hide resolved
src/Physics/NuElectron/XSection/PXSecOnElectron.h Outdated Show resolved Hide resolved
src/Physics/NuElectron/XSection/PXSecOnElectron.h Outdated Show resolved Hide resolved
src/Physics/NuElectron/XSection/PXSecOnElectron.h Outdated Show resolved Hide resolved
src/Physics/NuElectron/XSection/PXSecOnElectron.cxx Outdated Show resolved Hide resolved
src/Physics/NuclearState/BohrElectronVelocity.cxx Outdated Show resolved Hide resolved
@mroda88
Copy link
Member

mroda88 commented Sep 27, 2023

With this I had a look at the whole thing. On top of the "errors" I pointed out, I think we need a few testing macro, to verify that the events are produced in the right way.

I think we just need a loop over the events that extracts

  • the distribution of the hit electron
  • the y distribution of the interaction, as we want to prove that the old system and the new one are the same.

[edit] Following our conversation, you told me you have something already. Please upload it in src/contrib/electron_distribution/

…nt for neutrino direction, added validation to contrib, added invalid kinematics check
Copy link
Member

@mroda88 mroda88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few logical errors still

config/BardinIMDRadCorPXSec.xml Outdated Show resolved Hide resolved
config/IMDAnnihilationPXSec.xml Outdated Show resolved Hide resolved
src/Framework/Numerical/MathUtils.h Outdated Show resolved Hide resolved
src/Framework/Numerical/MathUtils.cxx Show resolved Hide resolved
src/Physics/NuElectron/XSection/IMDAnnihilationPXSec.cxx Outdated Show resolved Hide resolved
src/Physics/NuElectron/XSection/PXSecOnElectron.cxx Outdated Show resolved Hide resolved
src/contrib/electron_motion/validateNUE.C Show resolved Hide resolved
Copy link
Member

@mroda88 mroda88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are getting there. Some changes to be made.

Let's not forget the ValidKinematic check ow that the HitPartPdg is set correctly.
We need to understand if the energy threshold is evaluated correctly. in the framework.

.gitignore Outdated Show resolved Hide resolved
config/BardinIMDRadCorPXSec.xml Outdated Show resolved Hide resolved
config/IMDAnnihilationPXSec.xml Outdated Show resolved Hide resolved
config/PXSecOnElectron.xml Outdated Show resolved Hide resolved
config/PXSecOnElectron.xml Outdated Show resolved Hide resolved
src/contrib/electron_motion/validateNUE.C Outdated Show resolved Hide resolved
src/contrib/electron_motion/validateNUE.C Outdated Show resolved Hide resolved
src/contrib/electron_motion/validateNUE.C Outdated Show resolved Hide resolved
src/contrib/electron_motion/validateNUE.C Outdated Show resolved Hide resolved
Brinden Carlson added 2 commits October 5, 2023 10:17
Copy link
Member

@mroda88 mroda88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still problems with the handling of the threshold. As a matter of fact, we should check if IsAboveThreshold from the kinematic phase space does the right job now that we changed the interaction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework Framework related issues or improvements modelling Issues with any aspect of physics modelling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants