-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Electron Velocity Changes #331
base: master
Are you sure you want to change the base?
Implement Electron Velocity Changes #331
Conversation
…andomizer for bohr velocity
…into brindenc Updating my branch with nu e updates
…rection randomizer for bohr model
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Starting to make comments. Here are a few initial
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the changes are technical. There is one issue with the threshold though.
With this I had a look at the whole thing. On top of the "errors" I pointed out, I think we need a few testing macro, to verify that the events are produced in the right way. I think we just need a loop over the events that extracts
[edit] Following our conversation, you told me you have something already. Please upload it in |
…nt for neutrino direction, added validation to contrib, added invalid kinematics check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few logical errors still
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are getting there. Some changes to be made.
Let's not forget the ValidKinematic check ow that the HitPartPdg is set correctly.
We need to understand if the energy threshold is evaluated correctly. in the framework.
…d process. Updated .gitignore to remove my changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still problems with the handling of the threshold. As a matter of fact, we should check if IsAboveThreshold
from the kinematic phase space does the right job now that we changed the interaction.
…re xsec = 0 in integration
…re xsec = 0 in integration
No description provided.