Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make the rock toughness scalable with the fracture size and test anisotropic toughness #3310

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

frankfeifan
Copy link
Contributor

@frankfeifan frankfeifan commented Aug 28, 2024

This PR is to add and test features of rock toughness.

Scalable rock toughness

a new feature that makes the rock toughness scalable with the fracture size if the hydraulic fracture is very large. The underlying mechanism is that the cohesive region of rock fractures may scale up with the fracture size, thereby increasing the critical fracture energy and thus toughness. The specific formulation is

KIC = KIC_base*(1 + scalingFactor*sqrt(L)) where L is the distance to the fracture origin.

Here are the changes in this PR:

  • Change rockToughness to baseRockToughness, and add toughnessScalingFactor and fractureOrigin in SurfaceGenerator. fractureOrigin is manually input now, but can be removed later if we can find the fracture origin from the initial fracture geometry.
  • Plot K_IC by making it a field variable in fractureSubRegion,so that one can visualize the toughness in vtk.
  • Add a simple test to demonstrate the feature

Relevant references: Scholz, 2010, McClure, 2023

Anisotropic toughness

Existing hydrofracture solver has the capability to assign anisotropic toughness, but looks like there is no relevant test. An example is added to test this feature. Also, some changes may be needed to make this feature easier to use for users.

  • Add an example to test anisotropic rock toughness

@frankfeifan frankfeifan added changes XML input ci: run integrated tests Allows to run the integrated tests in GEOS CI labels Aug 28, 2024
@frankfeifan frankfeifan self-assigned this Aug 28, 2024
@frankfeifan frankfeifan changed the title Make the rock toughness scalable with the fracture size feature: Make the rock toughness scalable with the fracture size Aug 28, 2024
@frankfeifan frankfeifan changed the title feature: Make the rock toughness scalable with the fracture size feat: Make the rock toughness scalable with the fracture size Aug 28, 2024
@frankfeifan frankfeifan added the flag: requires rebaseline Requires rebaseline branch in integratedTests label Aug 28, 2024
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 39 lines in your changes missing coverage. Please review.

Project coverage is 56.57%. Comparing base (3b5b5a6) to head (af20655).

Files with missing lines Patch % Lines
...sicsSolvers/surfaceGeneration/SurfaceGenerator.cpp 0.00% 36 Missing ⚠️
...sicsSolvers/surfaceGeneration/SurfaceGenerator.hpp 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3310      +/-   ##
===========================================
- Coverage    56.59%   56.57%   -0.02%     
===========================================
  Files         1064     1064              
  Lines        89766    89797      +31     
===========================================
  Hits         50807    50807              
- Misses       38959    38990      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frankfeifan frankfeifan added the ci: run CUDA builds Allows to triggers (costly) CUDA jobs label Aug 29, 2024
@@ -521,7 +526,10 @@ class SurfaceGenerator : public SolverBase

//TODO: rock toughness should be a material parameter, and we need to make rock toughness to KIC a constitutive
// relation.
constexpr static char const * rockToughnessString() { return "rockToughness"; }
constexpr static char const * baseRockToughnessString() { return "baseRockToughness"; }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe initialRockToughness ?

@frankfeifan frankfeifan changed the title feat: Make the rock toughness scalable with the fracture size feat: Make the rock toughness scalable with the fracture size and test anisotropic toughness Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes XML input ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: requires rebaseline Requires rebaseline branch in integratedTests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants