Swaziri/experimental #3348
Draft
Swaziri/experimental #3348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anicsEFEM_impl.hpp
…stick condition. now it gets updated after newton converges
paveltomin
reviewed
Sep 23, 2024
| arrayView2d< real64 const > const & traction = subRegion.getField< fields::contact::traction >(); | ||
| arrayView1d< real64 const > const & pressure = subRegion.template getField< fields::flow::pressure >(); |
… into swaziri/experimental
paveltomin
reviewed
Sep 24, 2024
| @@ -269,7 +280,7 @@ inline void CoulombFrictionUpdates::computeShearTraction( localIndex const k, | |||
| dTractionVector_dJump[2][2] = m_shearStiffness; | |||
|
|
|||
| // The slip is only elastic: we add the full slip to the elastic one | |||
| LvArray::tensorOps::add< 2 >( m_elasticSlip[k], slip ); | |||
| //LvArray::tensorOps::add< 2 >( m_elasticSlip[k], slip ); | |||
There was a problem hiding this comment.
@CusiniM this update and update on the lines 314-315 below got moved into updateFractureState.
The reason is: those quantities should not be updated at every Newton but once at the end of the time step insted.
updateFractureState is probably not the best place either, what would be the better one?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.