Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Enable reservoir+wells+contact mechanics #3356

Merged
merged 14 commits into from
Oct 15, 2024
Merged

feat: Enable reservoir+wells+contact mechanics #3356

merged 14 commits into from
Oct 15, 2024

Conversation

paveltomin
Copy link
Contributor

@paveltomin paveltomin commented Sep 13, 2024 •
edited
Loading

  • fim
  • sequential
  • test cases

@paveltomin paveltomin marked this pull request as draft September 13, 2024 21:39
@paveltomin paveltomin marked this pull request as ready for review September 14, 2024 23:37
@paveltomin paveltomin self-assigned this Sep 14, 2024
@paveltomin paveltomin added the type: feature New feature or request label Sep 14, 2024
@paveltomin paveltomin changed the title Enable reservoir+wells+contact mechanics feat: Enable reservoir+wells+contact mechanics Sep 14, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 22.22222% with 14 lines in your changes missing coverage. Please review.

Project coverage is 56.48%. Comparing base (50aa846) to head (a026eb2).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...physicsSolvers/fluidFlow/wells/SinglePhaseWell.cpp 26.66% 11 Missing ⚠️
...ents/physicsSolvers/multiphysics/CoupledSolver.hpp 0.00% 2 Missing ⚠️
src/coreComponents/physicsSolvers/SolverBase.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #3356   +/-   ##
========================================
  Coverage    56.47%   56.48%           
========================================
  Files         1074     1074           
  Lines        90499    90502    +3     
========================================
+ Hits         51113    51118    +5     
+ Misses       39386    39384    -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paveltomin paveltomin added the ci: run CUDA builds Allows to triggers (costly) CUDA jobs label Oct 9, 2024
@paveltomin paveltomin added ci: run integrated tests Allows to run the integrated tests in GEOS CI ci: run code coverage enables running of the code coverage CI jobs labels Oct 9, 2024
@paveltomin
Copy link
Contributor Author

@CusiniM, @MelReyCG, @castelletto1, @corbett5, @rrsettgast, @untereiner, and/or @wrtobin could you please review?

CusiniM
CusiniM reviewed Oct 14, 2024
View reviewed changes
src/coreComponents/common/format/table/TableFormatter.cpp Outdated
@@ -169,7 +169,6 @@ string TableTextFormatter::toString( TableData const & tableData ) const

outputLayout( tableOutput, columns, msgTableError, sectionSeparatingLine );
outputSectionRows( columns, sectionSeparatingLine, tableOutput, nbValuesRows, TableLayout::Section::values );
tableOutput << '\n';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

won't this affect other tables as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will and I hate that additional line break

Copy link
Collaborator

@CusiniM CusiniM Oct 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, maybe a separate small PR for this would be better. Unless it's a known issue. What tables are these we are writing to the log?

Also coz if you move it to its own PR you get rid of some codeowners and we can merge this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok let me revert

@paveltomin paveltomin added flag: requires rebaseline Requires rebaseline branch in integratedTests and removed flag: ready for review labels Oct 15, 2024
@paveltomin
Copy link
Contributor Author

rebaseline needed because of allowNegativePressure flag added for wells

@paveltomin paveltomin merged commit a0a6e22 into develop Oct 15, 2024
24 of 25 checks passed
@paveltomin paveltomin deleted the pt/seq-wells-frac branch October 15, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CusiniM CusiniM CusiniM approved these changes

@jhuang2601 jhuang2601 jhuang2601 approved these changes

@castelletto1 castelletto1 Awaiting requested review from castelletto1 castelletto1 is a code owner

@rrsettgast rrsettgast Awaiting requested review from rrsettgast rrsettgast is a code owner

@wrtobin wrtobin Awaiting requested review from wrtobin wrtobin is a code owner

@untereiner untereiner Awaiting requested review from untereiner untereiner is a code owner

@klevzoff klevzoff Awaiting requested review from klevzoff

@francoishamon francoishamon Awaiting requested review from francoishamon

@cssherman cssherman Awaiting requested review from cssherman cssherman is a code owner

@tjb-ltk tjb-ltk Awaiting requested review from tjb-ltk

Assignees

@paveltomin paveltomin

Labels
ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: requires rebaseline Requires rebaseline branch in integratedTests type: feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paveltomin @CusiniM @jhuang2601