Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for ExtData2G unit test on discover GNU #3347

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

mathomp4
Copy link
Member

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

In testing MAPL on Discover with GNU, it was found the ExtData2G unit tests were failing. There were two issues:

  1. The overall test uses ESMF, but wasn't run with mpirun. On discover, all MPI code must be executed via mpirun
  2. The test still had an issue with a couple unit tests internally not handling an expected failure.

These fixes were due to the kind help of @darianboggs and @tclune

Related Issue

@mathomp4 mathomp4 added 🪲 Bugfix This fixes a bug! 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. labels Jan 17, 2025
@mathomp4 mathomp4 self-assigned this Jan 17, 2025
@mathomp4 mathomp4 requested a review from a team as a code owner January 17, 2025 18:16
@mathomp4
Copy link
Member Author

Sigh. I guess it fixed in one place and broke everywhere else. I'll take a look...

@mathomp4 mathomp4 marked this pull request as draft January 17, 2025 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🪲 Bugfix This fixes a bug!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant