Skip to content

Commit

Permalink
Fix typo and remove unused methods.
Browse files Browse the repository at this point in the history
  • Loading branch information
GOB52 committed Aug 24, 2022
1 parent c695770 commit a14d8d1
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 13 deletions.
2 changes: 1 addition & 1 deletion src/ponko_avatar.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ Avatar::Avatar()
_face->createFromBmp(ponko_face_bmp, ponko_face_bmp_len);

auto mc = new LGFX_Sprite();
assert(mc && "mo is nullptr");
assert(mc && "mc is nullptr");
mc->createFromBmp(ponko_mouth_close_bmp, ponko_mouth_close_bmp_len);
_mouth[Close] = mc;

Expand Down
1 change: 0 additions & 1 deletion src/wxbeacon2.cpp
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
/*!
@file wxbeacon2.cpp
@brief WxBeacon2 definitions [OMRON 2JCIE-BL01]
@note hardware independent
*/
#include "wxbeacon2.hpp"
#include <algorithm>
Expand Down
11 changes: 5 additions & 6 deletions src/wxbeacon2.hpp
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
/*!
@file wxbeacon2.hpp
@brief WxBeacon2 definitions [OMRON 2JCIE-BL01]
@note independent
*/
#ifndef WXBEACON2_HPP
#define WXBEACON2_HPP
Expand Down Expand Up @@ -462,7 +461,7 @@ class WxBeacon2

constexpr static uint16_t DEFAULT_VALUE = 300; // 300 sec => 5 min

/// @name Comvert
/// @name Convert
/// @{
explicit operator std::string() const { return std::string(_array.begin(), _array.end()); }
bool from(const std::string& v);
Expand All @@ -483,7 +482,7 @@ class WxBeacon2

explicit TimeInformation(time_t t = 0) : _time32(static_cast<uint32_t>(t)) {}

/// @name Comvert
/// @name Convert
/// @{
explicit operator std::string() const { return std::string(_array.begin(), _array.end()); }
bool from(const std::string& v);
Expand All @@ -505,7 +504,7 @@ class WxBeacon2

explicit LED(uint8_t d = DURATION_MIN) : _duration(d) {}

/// @name Comvert
/// @name Convert
/// @{
explicit operator std::string() const { return std::string(_array.begin(), _array.end()); }
/// @}
Expand Down Expand Up @@ -548,7 +547,7 @@ class WxBeacon2
bool hasError() const { return _sensor || _cpu || _battery; }
void clear() { _array = {}; }

/// @name Comvert
/// @name Convert
/// @{
explicit operator std::string() const { return std::string(_array.begin(), _array.end()); }
bool from(const std::string& v);
Expand Down Expand Up @@ -585,7 +584,7 @@ class WxBeacon2
bool withDataRecordingMode() const { return WxBeacon2::withDataRecordingMode(beaconMode()); }
bool withoutDataRecordingMode() const { return !WxBeacon2::withDataRecordingMode(beaconMode()); }

/// @name Comvert
/// @name Convert
/// @{
explicit operator std::string() const { return std::string(_array.begin(), _array.end()); }
bool from(const std::string& v);
Expand Down
5 changes: 0 additions & 5 deletions src/wxbeacon2_ble.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -150,11 +150,6 @@ class WxBeacon2Client
/// @}

protected:
bool correctDeviceName();
bool correctDeviceInformation();
bool correctADVSetting();
bool correctTimeInformation();

/*!
@brief get rows from 1 page.
@param page Read page no.
Expand Down

0 comments on commit a14d8d1

Please sign in to comment.