Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize operator overloading for XYZ objects #524

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

LSchwiebert
Copy link
Collaborator

This pull request creates a more efficient implementation of many of the overloaded operators for the XYZ class. It should run faster and is more readable. It is a cleaner C++ implementation of the XYZ class.

It also changes the XYZ struct to an XYZ class, although making the data members private is complicated by the fact that many other classes access these variables directly. So, they are currently kept as public members.

Also, removed some unused types and UNUSED, which isn't used in the code.

Copy link
Collaborator

@jpotoff jpotoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Produces matching results for simulations without MultiparticleGas True. Suspect there is another issue that is not related to this patch causing subtle differences in the gas phase multiparticle calculation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants