GPII-884: Implement reading data from sensors within an Android platform #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* For now, only added support for the light sensor
Changes: * Polihing a few details around light sensor * Adding noise sensor
| fluid.registerNamespace("gpii.androidSensors"); | ||
|
|
||
| gpii.androidSensors.getEndPoint = function () { | ||
| var androidSensors = bridge.load("net.gpii.AndroidSensorsImpl", thatall); |
There was a problem hiding this comment.
Makes more sense to cache this in a namespaced global rather than make repeated use of the bizarre "thatall" global. I assume that the implementation isn't so bizarre that it produces a different response for each call to bridge.load
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still a first implementation of this feature and can be tested with this KASPARNET's branch of universal
This pull requests adds the ability in the android implementation to report changes on the environmental data to the flow manager. Right now we're reporting changes about luminosity and environmental noise to the flow manager by making a PUT request to http://localhost:8081/environmentChanged, and according to this API contract