✨ [#133] Implement streaming/downloading file content #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
sergei-maertens
force-pushed
the
feature/133-document-download
branch
from
d189520 to
6f4d314
Compare
sergei-maertens
force-pushed
the
feature/133-document-download
branch
2 times, most recently
from
4dcbfdf to
68a220e
Compare
The binary content of the uploaded document is streamed down directly from the upstream Documenten API.
sergei-maertens
force-pushed
the
feature/133-document-download
branch
from
1972e47 to
ae2b37e
Compare
bart-maykin
reviewed
Nov 14, 2024
| @@ -33,6 +33,7 @@ | |||
|
|
|||
|
|
|||
| class Publication(models.Model): | |||
| id: int # implicitly provided by django | |||
There was a problem hiding this comment.
Why is this necessary?
There was a problem hiding this comment.
I updated the type in the factory, so now pyright knows that DocumentFactory.create() returns a Document, and existing tests have assertions using Document.id which pyright didn't understand because it's Django magic.
There was a problem hiding this comment.
bart-maykin
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #133
Changes