Document api update metadata fields #143
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
|
|
||
| class Meta(DocumentSerializer.Meta): | ||
| fields = DocumentSerializer.Meta.fields | ||
| read_only_fields = [ |
There was a problem hiding this comment.
I want to dynamically make all fields that we don't want to edit read_only=True.
This way when we update the parent serializer those fields won't suddenly end up in put/patch endpoints.
But this is a very ugly way of doing it. I wanted to do it by editing the get_field method but because we base this serializer on the DocumentSerializer the super() gave me a lot of trouble while trying to set it up. So I ended up doing it this way. What do you think is a better way of tackling this problem @sergei-maertens ?
There was a problem hiding this comment.
I tried to manipulate the get_fields within the DocumentSerializer which worked functionally but drf-spectacular didn't detect it so I think that this is the best course of action for now.
…ta fields, created specific serializer for the update and dynamically fill in the read_only_fields excepted the fields we want to edit.
…the DocumentApiAuthorizationAndPermissionTests to include the unsafe actions
sergei-maertens
force-pushed
the
feature/142-document-update-metadata-in-admin
branch
from
b17d733 to
15bc6db
Compare
sergei-maertens
deleted the
feature/142-document-update-metadata-in-admin
branch
Fixes #142
Changes
Created new document serializer for metadata field update