Fix build on clang < 13 #2888
Merged
Fix build on clang < 13 #2888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An explicit std::move is needed to select the correct Error cctor. This was introduced in c7656ef
|
@chuang13 This does not need porting to the internal repo. |
jasilvanus
approved these changes
Dec 19, 2023
Test summary for commit fbe2414CTS tests (Failed: 0/138443)
Ubuntu navi3x, SrdcvkUbuntu navi2x, Srdcvk |
Flakebi
approved these changes
Dec 19, 2023
qiaojbao
pushed a commit
that referenced
this pull request
Jan 2, 2024
An explicit std::move is needed to select the correct Error cctor. This was introduced in c7656ef
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An explicit std::move is needed to select the correct Error constructor.
The error was introduced in c7656ef