Local and Remote Development Setup; Initial Data Validation Use Case; Basic Database Migrations #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Working on dev deploy Working on dev deployment Fix typo Try Procfile Still working on dev deployment Trying a new approach to dev deploy Update imports in app context ga Revert Add alembic to handle migrations Fix alembic hookup to db Formatting Format alembic files Trying to set up hot reloading Tweak docker configuration Add container and image names back to compose.yml Fix alembic migrations Working on Minio integration for local dev Continue trying to get boto3 to connect to minio Successfully test s3 interface Successfully test s3 interface Remove artifact First data handling use case Tweak message to user Remove artifact Add test case for new use case Test example validation function Add types to validation function Format and add comments to Dockerfile Refactor filename logic Tweak fake/mock filename Revert to previous storage handling method Make small refinements to temp file handling Change way task is initiated Update Dockerfile so that root user no longer runs app and queue Remove extraneous code Update ingest use rcase to print out filename Housekeeping re contracts for application services Use data class for download result instead of anonymous tuple Clean up docker files Add example env file and update readme to let user know they need to set it up
danielnaab
approved these changes
Feb 6, 2024
| ctx.logger.error("Data submission with that filename does not exist") | ||
| return | ||
|
|
||
| download_result: DownloadResult = ctx.storage.download_temp(filename) |
There was a problem hiding this comment.
This isn't necessary at all, but a custom context manager for the temp directory might be nice here, so you could use the with keyword and avoid the manual cleanup cleanup_temp_dir step.
There was a problem hiding this comment.
I'll add an issue to refactor this.
| S3_ENDPOINT = os.getenv("S3_ENDPOINT") | ||
| S3_ACCESS_KEY = os.getenv("S3_ACCESS_KEY") | ||
| S3_SECRET_ACCESS_KEY = os.getenv("S3_SECRET_ACCESS_KEY") | ||
| S3_REGION = os.getenv("S3_REGION") |
There was a problem hiding this comment.
I wonder if this is maybe a bit redundant with the app context. Perhaps it could be merged into this module?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are thee areas of change accounted for in this PR: