Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Normalization of Award Reference Lengths for Consistency in Workbook Validation #4331

Closed
sambodeme opened this issue Sep 27, 2024 · 0 comments
Assignees

Comments

@sambodeme
Copy link
Contributor

Description:

Modify the check_award_ref_declaration function to ensure that discrepancies in award reference lengths between the Federal Awards workbook and the Federal Awards Audit Findings workbook are normalized before validation. This involves:

  1. Creating a helper function to handle cases where award references have differing lengths by padding shorter references with leading zeros.
  2. Ensuring that if the declared award reference length is greater or less than the reported award reference length, references are adjusted to match in both workbooks.
  3. Incorporating the normalization step before checking for mismatches between reported and declared award references.

This will ensure consistent validation across different versions of the workbooks and prevent errors due to differing reference lengths.

@github-project-automation github-project-automation bot moved this to Triage in FAC Sep 27, 2024
@sambodeme sambodeme moved this from Triage to In Progress in FAC Sep 27, 2024
@sambodeme sambodeme self-assigned this Sep 27, 2024
sambodeme added a commit that referenced this issue Sep 27, 2024
sambodeme added a commit that referenced this issue Oct 1, 2024
github-merge-queue bot pushed a commit that referenced this issue Oct 4, 2024
* #4331 Updated logic to handle discrepancies in award reference lengths

* #4331 Removed  unused REGEX

* #4331 Update validation on finding count to account for award reference version mismatch
@sambodeme sambodeme moved this from In Progress to Done in FAC Oct 15, 2024
@danswick danswick moved this from Done to Backlog in FAC Nov 8, 2024
@danswick danswick closed this as completed Nov 8, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in FAC Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants