Add Cross Validation for total_amount_expended < DOLLAR_THRESHOLD #4128
Conversation
|
Terraform plan for dev Plan: 1 to add, 0 to change, 1 to destroy.Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
-/+ destroy and then create replacement
Terraform will perform the following actions:
# module.dev.module.cors.null_resource.cors_header must be replaced
-/+ resource "null_resource" "cors_header" {
!~ id = "******************" -> (known after apply)
!~ triggers = { # forces replacement
!~ "always_run" = "2024-07-29T18:02:36Z" -> (known after apply)
}
}
Plan: 1 to add, 0 to change, 1 to destroy.
Warning: Argument is deprecated
with module.dev-backups-bucket.cloudfoundry_service_instance.bucket,
on /tmp/terraform-data-dir/modules/dev-backups-bucket/s3/main.tf line 14, in resource "cloudfoundry_service_instance" "bucket":
14: recursive_delete = var.recursive_delete
Since CF API v3, recursive delete is always done on the cloudcontroller side.
This will be removed in future releases
(and 6 more similar warnings elsewhere)📝 Plan generated in Pull Request Checks #3390 |
|
Terraform plan for meta No changes. Your infrastructure matches the configuration.📝 Plan generated in Pull Request Checks #3390 |
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
There was a problem hiding this comment.
I suggest moving this to intakelib/checks instead. The reasoning behind cross-validation is that these validations perform checks involving more than a single section. In this case, all the information needed to perform the validation is available at intake time and only requires the federal award workbook, so it is more appropriate to perform the validation right when the workbook is being submitted. We also have a few checks in cross-validation, including check_award_ref_existence, check_award_reference_uniqueness, and check_finding_reference_uniqueness, that we will want to move into intakelib/checks due to the nature of their checks, but that is beyond the scope of this PR.
|
Closing this as superseded by 4198. The code can/will remain for reference, but it makes more sense to implement this when we have multiple thresholds to validate for. |
Add Cross Validation for total_amount_expended < DOLLAR_THRESHOLD
Issue: closes #3869
Changes:
Add
check_total_amount_expendedto the cross validation functions.errors.pytotal_amount_expended- at, above, or below the thresholdHow to test:
total_amount_expendedScreenshots:
The error message:
PR checklist: submitters
maininto your branch shortly before creating the PR. (You should also be mergingmaininto your branch regularly during development.)git status | grep migrations. If there are any results, you probably need to add them to the branch for the PR. Your PR should have only one new migration file for each of the component apps, except in rare circumstances; you may need to delete some and re-runpython manage.py makemigrationsto reduce the number to one. (Also, unless in exceptional circumstances, your PR should not delete any migration files.)PR checklist: reviewers
make docker-clean; make docker-first-run && docker compose up; then rundocker compose exec web /bin/bash -c "python manage.py test"The larger the PR, the stricter we should be about these points.