-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sandbox Environment #4383
Merged
Merged
Sandbox Environment #4383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terraform plan for meta No changes. Your infrastructure matches the configuration.
✅ Plan applied in Deploy to Development and Management Environment #854 |
Terraform plan for dev Plan: 1 to add, 2 to change, 1 to destroy.Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
!~ update in-place
-/+ destroy and then create replacement
Terraform will perform the following actions:
# module.dev.module.clamav.cloudfoundry_app.clamav_api will be updated in-place
!~ resource "cloudfoundry_app" "clamav_api" {
!~ docker_image = "ghcr.io/gsa-tts/fac/clamav@sha256:e6f7ded85a1a59c9c8d9ea24d7165d1bb8332f49291e211e2d6e12fc13ac9131" -> "ghcr.io/gsa-tts/fac/clamav@sha256:d9939eb2fb908460f98dac636d4a9d7cb7f0befa08db7ae67bacbee9fa4967a2"
id = "779bbc51-f78a-4186-90eb-5acb68d7d746"
name = "fac-av-dev"
# (17 unchanged attributes hidden)
# (1 unchanged block hidden)
}
# module.dev.module.cors.null_resource.cors_header must be replaced
-/+ resource "null_resource" "cors_header" {
!~ id = "*******************" -> (known after apply)
!~ triggers = { # forces replacement
!~ "always_run" = "2024-10-31T16:57:29Z" -> (known after apply)
}
}
# module.dev.module.file_scanner_clamav.cloudfoundry_app.clamav_api will be updated in-place
!~ resource "cloudfoundry_app" "clamav_api" {
!~ docker_image = "ghcr.io/gsa-tts/fac/clamav@sha256:e6f7ded85a1a59c9c8d9ea24d7165d1bb8332f49291e211e2d6e12fc13ac9131" -> "ghcr.io/gsa-tts/fac/clamav@sha256:d9939eb2fb908460f98dac636d4a9d7cb7f0befa08db7ae67bacbee9fa4967a2"
id = "65c83416-4126-4785-99c2-5e1adb810422"
name = "fac-av-dev-fs"
# (17 unchanged attributes hidden)
# (1 unchanged block hidden)
}
Plan: 1 to add, 2 to change, 1 to destroy.
Warning: Argument is deprecated
with module.dev-backups-bucket.cloudfoundry_service_instance.bucket,
on /tmp/terraform-data-dir/modules/dev-backups-bucket/s3/main.tf line 14, in resource "cloudfoundry_service_instance" "bucket":
14: recursive_delete = var.recursive_delete
Since CF API v3, recursive delete is always done on the cloudcontroller side.
This will be removed in future releases
(and 6 more similar warnings elsewhere) ✅ Plan applied in Deploy to Development and Management Environment #854 |
asteel-gsa
commented
Oct 15, 2024
asteel-gsa
commented
Oct 15, 2024
asteel-gsa
commented
Oct 15, 2024
asteel-gsa
commented
Oct 15, 2024
asteel-gsa
commented
Oct 15, 2024
asteel-gsa
commented
Oct 15, 2024
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
asteel-gsa
force-pushed
the
workstation-bootstrap
branch
from
October 15, 2024 14:43
103765e
to
27845ef
Compare
asteel-gsa
force-pushed
the
workstation-bootstrap
branch
from
October 17, 2024 14:29
154b291
to
85eba2e
Compare
asteel-gsa
force-pushed
the
workstation-bootstrap
branch
from
November 4, 2024 15:03
da8b61b
to
e3898ca
Compare
sambodeme
approved these changes
Nov 5, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fairly extensive PR that I would like to have 1-2 more folks test before merging. This has been tested, built, destroyed, and rebuilt by Matt as well as myself.
Description
Fundamentally, nothing changes except the following:
helper_scripts
directory tosandbox
to allow for easy./
commands to plan, apply and destroy the environmenthttps-proxy
calledsandbox-proxy
as the core change to this is what module manages the routesshared/sandbox/routes.tf
rather than where they were (clamav and https-proxy)"SANDBOX"
tosettings.py