Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sandbox Environment #4383

Merged
merged 101 commits into from
Nov 5, 2024
Merged

Sandbox Environment #4383

merged 101 commits into from
Nov 5, 2024

Conversation

asteel-gsa
Copy link
Contributor

@asteel-gsa asteel-gsa commented Oct 15, 2024

This is a fairly extensive PR that I would like to have 1-2 more folks test before merging. This has been tested, built, destroyed, and rebuilt by Matt as well as myself.

Description

Fundamentally, nothing changes except the following:

  • Adds helper_scripts directory to sandbox to allow for easy ./ commands to plan, apply and destroy the environment
  • Creates a clone of https-proxy called sandbox-proxy as the core change to this is what module manages the routes
    • Routes now located in shared/sandbox/routes.tf rather than where they were (clamav and https-proxy)
  • Detailed README on how to use sandbox
  • Adds "SANDBOX" to settings.py

Copy link
Contributor

github-actions bot commented Oct 15, 2024

Terraform plan for meta

No changes. Your infrastructure matches the configuration.
No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.

Warning: Argument is deprecated

  with module.s3-backups.cloudfoundry_service_instance.bucket,
  on /tmp/terraform-data-dir/modules/s3-backups/s3/main.tf line 14, in resource "cloudfoundry_service_instance" "bucket":
  14:   recursive_delete = var.recursive_delete

Since CF API v3, recursive delete is always done on the cloudcontroller side.
This will be removed in future releases

✅ Plan applied in Deploy to Development and Management Environment #854

Copy link
Contributor

github-actions bot commented Oct 15, 2024

Terraform plan for dev

Plan: 1 to add, 2 to change, 1 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
!~  update in-place
-/+ destroy and then create replacement

Terraform will perform the following actions:

  # module.dev.module.clamav.cloudfoundry_app.clamav_api will be updated in-place
!~  resource "cloudfoundry_app" "clamav_api" {
!~      docker_image                    = "ghcr.io/gsa-tts/fac/clamav@sha256:e6f7ded85a1a59c9c8d9ea24d7165d1bb8332f49291e211e2d6e12fc13ac9131" -> "ghcr.io/gsa-tts/fac/clamav@sha256:d9939eb2fb908460f98dac636d4a9d7cb7f0befa08db7ae67bacbee9fa4967a2"
        id                              = "779bbc51-f78a-4186-90eb-5acb68d7d746"
        name                            = "fac-av-dev"
#        (17 unchanged attributes hidden)

#        (1 unchanged block hidden)
    }

  # module.dev.module.cors.null_resource.cors_header must be replaced
-/+ resource "null_resource" "cors_header" {
!~      id       = "*******************" -> (known after apply)
!~      triggers = { # forces replacement
!~          "always_run" = "2024-10-31T16:57:29Z" -> (known after apply)
        }
    }

  # module.dev.module.file_scanner_clamav.cloudfoundry_app.clamav_api will be updated in-place
!~  resource "cloudfoundry_app" "clamav_api" {
!~      docker_image                    = "ghcr.io/gsa-tts/fac/clamav@sha256:e6f7ded85a1a59c9c8d9ea24d7165d1bb8332f49291e211e2d6e12fc13ac9131" -> "ghcr.io/gsa-tts/fac/clamav@sha256:d9939eb2fb908460f98dac636d4a9d7cb7f0befa08db7ae67bacbee9fa4967a2"
        id                              = "65c83416-4126-4785-99c2-5e1adb810422"
        name                            = "fac-av-dev-fs"
#        (17 unchanged attributes hidden)

#        (1 unchanged block hidden)
    }

Plan: 1 to add, 2 to change, 1 to destroy.

Warning: Argument is deprecated

  with module.dev-backups-bucket.cloudfoundry_service_instance.bucket,
  on /tmp/terraform-data-dir/modules/dev-backups-bucket/s3/main.tf line 14, in resource "cloudfoundry_service_instance" "bucket":
  14:   recursive_delete = var.recursive_delete

Since CF API v3, recursive delete is always done on the cloudcontroller side.
This will be removed in future releases

(and 6 more similar warnings elsewhere)

✅ Plan applied in Deploy to Development and Management Environment #854

terraform/dev/init.sh Outdated Show resolved Hide resolved
backend/gunicorn.conf.py Outdated Show resolved Hide resolved
backend/Procfile Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Oct 15, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
18789 17108 91% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 27845ef by action🐍

Copy link
Contributor

github-actions bot commented Nov 5, 2024

Code Coverage

Package Line Rate Branch Rate Health
. 100% 100%
api 98% 90%
audit 97% 87%
audit.cross_validation 98% 86%
audit.fixtures 84% 50%
audit.intakelib 90% 81%
audit.intakelib.checks 92% 85%
audit.intakelib.common 98% 82%
audit.intakelib.transforms 100% 94%
audit.management.commands 78% 17%
audit.migrations 100% 100%
audit.models 93% 75%
audit.templatetags 100% 100%
audit.views 61% 41%
census_historical_migration 96% 65%
census_historical_migration.migrations 100% 100%
census_historical_migration.sac_general_lib 92% 84%
census_historical_migration.transforms 95% 90%
census_historical_migration.workbooklib 68% 69%
config 78% 17%
curation 100% 100%
curation.curationlib 57% 100%
curation.migrations 100% 100%
dissemination 91% 72%
dissemination.migrations 97% 25%
dissemination.searchlib 74% 64%
dissemination.templatetags 100% 100%
djangooidc 53% 38%
djangooidc.tests 100% 94%
report_submission 93% 88%
report_submission.migrations 100% 100%
report_submission.templatetags 74% 100%
support 95% 78%
support.management.commands 96% 100%
support.migrations 100% 100%
support.models 97% 83%
tools 98% 50%
users 98% 100%
users.fixtures 100% 83%
users.management 100% 100%
users.management.commands 100% 100%
users.migrations 100% 100%
Summary 91% (17131 / 18906) 77% (2116 / 2764)

@asteel-gsa asteel-gsa added this pull request to the merge queue Nov 5, 2024
Merged via the queue into main with commit 515c920 Nov 5, 2024
15 checks passed
@asteel-gsa asteel-gsa deleted the workstation-bootstrap branch November 5, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert the application to be Terraform exclusive
4 participants