Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating a dashboard that displays details at the endpoint level. #4643

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gsa-jrothacker
Copy link
Contributor

@gsa-jrothacker gsa-jrothacker commented Jan 17, 2025

Summary

The goal of this PR is to add additional dashboarding into new relic. This will generate a new dashboard called "FAC Monitoring - ". It contains a high level dashboard for a quick overview of FAC as a whole, then the second page has details for individual endpoints.

Note: This is for monitoring only, there is no alarming configured.

Issue

Testing

I ran this in preview and overrode the environment to production. You can see the dashboard it created by looking in new relic for "FAC Monitoring - Production"

What's Next?

Add more endpoints. Consider breaking them up across multiple pages (e.g. Audit, Dissemination, Search, ect.)
Consider adding additional alarming using the same endpoint configurations.
Consider making the endpoint configuration environment specific (e.g. dev will likely always be "red" for transactions)

PR Checklist: Submitter

  • Link to an issue if possible. If there’s no issue, describe what your branch does. Even if there is an issue, a brief description in the PR is still useful.
  • List any special steps reviewers have to follow to test the PR. For example, adding a local environment variable, creating a local test file, etc.
  • For extra credit, submit a screen recording like this one.
  • Make sure you’ve merged main into your branch shortly before creating the PR. (You should also be merging main into your branch regularly during development.)
  • Make sure you’ve accounted for any migrations. When you’re about to create the PR, bring up the application locally and then run git status | grep migrations. If there are any results, you probably need to add them to the branch for the PR. Your PR should have only one new migration file for each of the component apps, except in rare circumstances; you may need to delete some and re-run python manage.py makemigrations to reduce the number to one. (Also, unless in exceptional circumstances, your PR should not delete any migration files.)
  • Make sure that whatever feature you’re adding has tests that cover the feature. This includes test coverage to make sure that the previous workflow still works, if applicable.
  • Make sure the full-submission.cy.js Cypress test passes, if applicable.
  • Do manual testing locally. Our tests are not good enough yet to allow us to skip this step. If that’s not applicable for some reason, check this box.
  • Verify that no Git surgery was necessary, or, if it was necessary at any point, repeat the testing after it’s finished.
  • Once a PR is merged, keep an eye on it until it’s deployed to dev, and do enough testing on dev to verify that it deployed successfully, the feature works as expected, and the happy path for the broad feature area (such as submission) still works.
  • Ensure that prior to merging, the working branch is up to date with main and the terraform plan is what you expect.

PR Checklist: Reviewer

  • Pull the branch to your local environment and run make docker-clean; make docker-first-run && docker compose up; then run docker compose exec web /bin/bash -c "python manage.py test"
  • Manually test out the changes locally, or check this box to verify that it wasn’t applicable in this case.
  • Check that the PR has appropriate tests. Look out for changes in HTML/JS/JSON Schema logic that may need to be captured in Python tests even though the logic isn’t in Python.
  • Verify that no Git surgery is necessary at any point (such as during a merge party), or, if it was, repeat the testing after it’s finished.

The larger the PR, the stricter we should be about these points.

Pre Merge Checklist: Merger

  • Ensure that prior to approving, the terraform plan is what we expect it to be. -/+ resource "null_resource" "cors_header" should be destroying and recreating its self and ~ resource "cloudfoundry_app" "clamav_api" might be updating its sha256 for the fac-file-scanner and fac-av-${ENV} by default.
  • Ensure that the branch is up to date with main.
  • Ensure that a terraform plan has been recently generated for the pull request.

Copy link
Contributor

Terraform plan for meta

No changes. Your infrastructure matches the configuration.
No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.

📝 Plan generated in Pull Request Checks #4188

Copy link
Contributor

Terraform plan for dev

Plan: 2 to add, 0 to change, 1 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
+   create
-/+ destroy and then create replacement

Terraform will perform the following actions:

  # module.dev.module.cors.null_resource.cors_header must be replaced
-/+ resource "null_resource" "cors_header" {
!~      id       = "*******************" -> (known after apply)
!~      triggers = { # forces replacement
!~          "always_run" = "2025-01-15T20:24:56Z" -> (known after apply)
        }
    }

  # module.dev.module.newrelic.newrelic_one_dashboard_json.fac_monitoring will be created
+   resource "newrelic_one_dashboard_json" "fac_monitoring" {
+       account_id = (known after apply)
+       guid       = (known after apply)
+       id         = (known after apply)
+       json       = jsonencode(
            {
+               description = "FAC Monitoring"
+               name        = "FAC Monitoring - Dev"
+               pages       = [
+                   {
+                       description = null
+                       name        = "At A Glance"
+                       widgets     = [
+                           {
+                               layout            = {
+                                   column = 1
+                                   height = 3
+                                   row    = 2
+                                   width  = 2
                                }
+                               linkedEntityGuids = null
+                               rawConfiguration  = {
+                                   nrqlQueries = [
+                                       {
+                                           accountIds = [
+                                               3919076,
                                            ]
+                                           query      = "FROM SyntheticCheck SELECT percentage(count(result), WHERE result = 'SUCCESS') AS 'Uptime' WHERE monitorName = 'Fac Ping Dev' SINCE 1 hour ago"
                                        },
                                    ]
                                }
+                               title             = "Uptime (last hour)"
+                               visualization     = {
+                                   id = "viz.billboard"
                                }
                            },
+                           {
+                               layout            = {
+                                   column = 3
+                                   height = 3
+                                   row    = 1
+                                   width  = 2
                                }
+                               linkedEntityGuids = null
+                               rawConfiguration  = {
+                                   dataFormatters     = [
+                                       {
+                                           name      = "Uptime (%)"
+                                           precision = "4"
+                                           type      = "decimal"
                                        },
                                    ]
+                                   linkedEntityGuids  = []
+                                   nrqlQueries        = [
+                                       {
+                                           accountIds = [
+                                               3919076,
                                            ]
+                                           query      = "FROM SyntheticCheck SELECT percentage(count(result), WHERE result = 'SUCCESS') WHERE monitorName = 'Fac Ping Dev' SINCE 7 days ago"
                                        },
                                    ]
+                                   thresholds         = [
+                                       {
+                                           alertSeverity = "WARNING"
+                                           value         = 0.99
                                        },
+                                       {
+                                           alertSeverity = "CRITICAL"
+                                           value         = 0.95
                                        },
                                    ]
+                                   vizcoConfiguration = {
+                                       billboard      = {
+                                           thresholds = [
+                                               {
+                                                   limit = 0.99
+                                                   type  = "warning"
                                                },
+                                               {
+                                                   limit = 0.95
+                                                   type  = "critical"
                                                },
                                            ]
                                        }
+                                       dataFormatters = [
+                                           {
+                                               name      = "Uptime (%)"
+                                               precision = "4"
+                                               type      = "decimal"
                                            },
                                        ]
                                    }
                                }
+                               title             = "Uptime Target: Above 95%"
+                               visualization     = {
+                                   id = "viz.billboard"
                                }
                            },
+                           {
+                               layout            = {
+                                   column = 5
+                                   height = 3
+                                   row    = 1
+                                   width  = 6
                                }
+                               linkedEntityGuids = null
+                               rawConfiguration  = {
+                                   nrqlQueries = [
+                                       {
+                                           accountIds = [
+                                               3919076,
                                            ]
+                                           query      = "FROM SyntheticCheck SELECT percentage(count(result), WHERE result = 'SUCCESS') WHERE monitorName = 'Fac Ping Dev' SINCE 14 days AGO TIMESERIES"
                                        },
                                    ]
                                }
+                               title             = "Uptime"
+                               visualization     = {
+                                   id = "viz.line"
                                }
                            },
+                           {
+                               layout            = {
+                                   column = 1
+                                   height = 3
+                                   row    = 4
+                                   width  = 2
                                }
+                               linkedEntityGuids = null
+                               rawConfiguration  = {
+                                   nrqlQueries = [
+                                       {
+                                           accountIds = [
+                                               3919076,
                                            ]
+                                           query      = "FROM Transaction SELECT count(*) AS 'Transactions' WHERE appName = 'gsa-fac-dev' SINCE 1 hour ago"
                                        },
                                    ]
                                }
+                               title             = "Transactions (last hour)"
+                               visualization     = {
+                                   id = "viz.billboard"
                                }
                            },
+                           {
+                               layout            = {
+                                   column = 3
+                                   height = 3
+                                   row    = 4
+                                   width  = 2
                                }
+                               linkedEntityGuids = null
+                               rawConfiguration  = {
+                                   dataFormatters     = [
+                                       {
+                                           name      = "Transactions Per Hour"
+                                           precision = "0"
+                                           type      = "decimal"
                                        },
                                    ]
+                                   linkedEntityGuids  = []
+                                   nrqlQueries        = [
+                                       {
+                                           accountIds = [
+                                               3919076,
                                            ]
+                                           query      = "FROM Transaction SELECT rate(count(*), 1 hour) AS 'Transactions (per hour)' WHERE appName ='gsa-fac-dev' SINCE 7 days ago"
                                        },
                                    ]
+                                   thresholds         = [
+                                       {
+                                           alertSeverity = "WARNING"
+                                           value         = 300
                                        },
+                                       {
+                                           alertSeverity = "CRITICAL"
+                                           value         = 100
                                        },
                                    ]
+                                   vizcoConfiguration = {
+                                       billboard      = {
+                                           thresholds = [
+                                               {
+                                                   limit = 300
+                                                   type  = "warning"
                                                },
+                                               {
+                                                   limit = 100
+                                                   type  = "critical"
                                                },
                                            ]
                                        }
+                                       dataFormatters = [
+                                           {
+                                               name      = "Transactions Per Hour"
+                                               precision = "0"
+                                               type      = "decimal"
                                            },
                                        ]
                                    }
                                }
+                               title             = "Transactions Target: 100 (average per hour/last week)"
+                               visualization     = {
+                                   id = "viz.billboard"
                                }
                            },
+                           {
+                               layout            = {
+                                   column = 5
+                                   height = 3
+                                   row    = 4
+                                   width  = 6
                                }
+                               linkedEntityGuids = null
+                               rawConfiguration  = {
+                                   nrqlQueries = [
+                                       {
+                                           accountIds = [
+                                               3919076,
                                            ]
+                                           query      = "FROM Transaction SELECT count(*) AS 'Transactions' WHERE appName = 'gsa-fac-dev' SINCE 14 days ago TIMESERIES"
                                        },
                                    ]
                                }
+                               title             = "Transactions"
+                               visualization     = {
+                                   id = "viz.line"
                                }
                            },
+                           {
+                               layout            = {
+                                   column = 1
+                                   height = 3
+                                   row    = 7
+                                   width  = 2
                                }
+                               linkedEntityGuids = null
+                               rawConfiguration  = {
+                                   nrqlQueries = [
+                                       {
+                                           accountIds = [
+                                               3919076,
                                            ]
+                                           query      = "FROM TransactionError SELECT count(*) AS 'Errors (last hour)' SINCE 1 hour ago"
                                        },
                                    ]
                                }
+                               title             = "Errors (last hour)"
+                               visualization     = {
+                                   id = "viz.billboard"
                                }
                            },
+                           {
+                               layout            = {
+                                   column = 3
+                                   height = 3
+                                   row    = 7
+                                   width  = 2
                                }
+                               linkedEntityGuids = null
+                               rawConfiguration  = {
+                                   dataFormatters     = [
+                                       {
+                                           name      = "Success Rate (%)"
+                                           precision = "4"
+                                           type      = "decimal"
                                        },
                                    ]
+                                   linkedEntityGuids  = []
+                                   nrqlQueries        = [
+                                       {
+                                           accountIds = [
+                                               3919076,
                                            ]
+                                           query      = "FROM Transaction SELECT 100 - percentage(count(*), WHERE error is true) AS 'Success Rate' WHERE appName ='gsa-fac-dev' SINCE 7 days ago "
                                        },
                                    ]
+                                   thresholds         = [
+                                       {
+                                           alertSeverity = "WARNING"
+                                           value         = 0.985
                                        },
+                                       {
+                                           alertSeverity = "CRITICAL"
+                                           value         = 0.975
                                        },
                                    ]
+                                   vizcoConfiguration = {
+                                       billboard      = {
+                                           thresholds = [
+                                               {
+                                                   limit = 0.985
+                                                   type  = "warning"
                                                },
+                                               {
+                                                   limit = 0.975
+                                                   type  = "critical"
                                                },
                                            ]
                                        }
+                                       dataFormatters = [
+                                           {
+                                               name      = "Success Rate (%)"
+                                               precision = "4"
+                                               type      = "decimal"
                                            },
                                        ]
                                    }
                                }
+                               title             = "Success Rate Target: Above 97.5%"
+                               visualization     = {
+                                   id = "viz.billboard"
                                }
                            },
+                           {
+                               layout            = {
+                                   column = 5
+                                   height = 3
+                                   row    = 7
+                                   width  = 6
                                }
+                               linkedEntityGuids = null
+                               rawConfiguration  = {
+                                   nrqlQueries = [
+                                       {
+                                           accountIds = [
+                                               3919076,
                                            ]
+                                           query      = "FROM TransactionError SELECT count(*) AS 'Errors (last hour)' WHERE (appName = 'gsa-fac-dev') SINCE 14 days ago TIMESERIES"
                                        },
                                    ]
                                }
+                               title             = "Errors"
+                               visualization     = {
+                                   id = "viz.line"
                                }
                            },
+                           {
+                               layout            = {
+                                   column = 1
+                                   height = 3
+                                   row    = 10
+                                   width  = 2
                                }
+                               linkedEntityGuids = null
+                               rawConfiguration  = {
+                                   dataFormatters  = [
+                                       {
+                                           name = "p95"
+                                           type = "decimal"
                                        },
+                                       {
+                                           name = "p50"
+                                           type = "decimal"
                                        },
+                                       {
+                                           name = "Average"
+                                           type = "decimal"
                                        },
                                    ]
+                                   facet           = {
+                                       showOtherSeries = false
                                    }
+                                   nrqlQueries     = [
+                                       {
+                                           accountIds = [
+                                               3919076,
                                            ]
+                                           query      = "FROM Transaction SELECT average(convert(duration, 's', 'ms')) AS 'Average', percentile(convert(duration, 's', 'ms'), 50) AS 'p50', percentile(convert(duration, 's', 'ms'), 95) AS 'p95'  WHERE appName = 'gsa-fac-dev' SINCE 1 hour ago"
                                        },
                                    ]
+                                   platformOptions = {
+                                       ignoreTimeRange = false
                                    }
                                }
+                               title             = "Latency (last hour)"
+                               visualization     = {
+                                   id = "viz.billboard"
                                }
                            },
+                           {
+                               layout            = {
+                                   column = 3
+                                   height = 3
+                                   row    = 10
+                                   width  = 2
                                }
+                               linkedEntityGuids = null
+                               rawConfiguration  = {
+                                   dataFormatters     = [
+                                       {
+                                           name      = "Average Latency (ms)"
+                                           precision = "0"
+                                           type      = "decimal"
                                        },
                                    ]
+                                   linkedEntityGuids  = []
+                                   nrqlQueries        = [
+                                       {
+                                           accountIds = [
+                                               3919076,
                                            ]
+                                           query      = "FROM Transaction SELECT average(convert(duration, 's', 'ms')) AS 'Average' WHERE (appName = 'gsa-fac-dev') SINCE 7 days ago "
                                        },
                                    ]
+                                   thresholds         = [
+                                       {
+                                           alertSeverity = "CRITICAL"
+                                           value         = 1000
                                        },
+                                       {
+                                           alertSeverity = "WARNING"
+                                           value         = 800
                                        },
                                    ]
+                                   vizcoConfiguration = {
+                                       billboard      = {
+                                           thresholds = [
+                                               {
+                                                   limit = 1000
+                                                   type  = "critical"
                                                },
+                                               {
+                                                   limit = 800
+                                                   type  = "warning"
                                                },
                                            ]
                                        }
+                                       dataFormatters = [
+                                           {
+                                               name      = "Average Latency (ms)"
+                                               precision = "0"
+                                               type      = "decimal"
                                            },
                                        ]
                                    }
                                }
+                               title             = "Average Latency Target (last week): 1000ms"
+                               visualization     = {
+                                   id = "viz.billboard"
                                }
                            },
+                           {
+                               layout            = {
+                                   column = 5
+                                   height = 3
+                                   row    = 10
+                                   width  = 6
                                }
+                               linkedEntityGuids = null
+                               rawConfiguration  = {
+                                   facet           = {
+                                       showOtherSeries = false
                                    }
+                                   legend          = {
+                                       enabled = true
                                    }
+                                   nrqlQueries     = [
+                                       {
+                                           accountIds = [
+                                               3919076,
                                            ]
+                                           query      = "FROM Transaction SELECT average(duration) AS 'Average', percentile(duration, 50) AS 'p50', percentile(duration, 95) AS 'p95' WHERE appName = 'gsa-fac-dev' SINCE 14 days ago TIMESERIES"
                                        },
                                    ]
+                                   platformOptions = {
+                                       ignoreTimeRange = false
                                    }
+                                   thresholds      = {
+                                       isLabelVisible = true
                                    }
+                                   units           = {
+                                       unit = "MS"
                                    }
+                                   yAxisLeft       = {
+                                       zero = true
                                    }
+                                   yAxisRight      = {
+                                       zero = true
                                    }
                                }
+                               title             = "Latency"
+                               visualization     = {
+                                   id = "viz.line"
                                }
                            },
+                           {
+                               layout            = {
+                                   column = 1
+                                   height = 1
+                                   row    = 13
+                                   width  = 10
                                }
+                               linkedEntityGuids = null
+                               rawConfiguration  = {
+                                   text = "# Host Metrics"
                                }
+                               title             = ""
+                               visualization     = {
+                                   id = "viz.markdown"
                                }
                            },
+                           {
+                               layout            = {
+                                   column = 1
+                                   height = 3
+                                   row    = 14
+                                   width  = 5
                                }
+                               linkedEntityGuids = null
+                               rawConfiguration  = {
+                                   nrqlQueries = [
+                                       {
+                                           accountIds = [
+                                               3919076,
                                            ]
+                                           query      = "FROM Metric SELECT average(apm.service.cpu.usertime.utilization) * 100 as cpuUsage WHERE appName = 'gsa-fac-dev' FACET `host` LIMIT 20 SINCE 7 days ago TIMESERIES"
                                        },
                                    ]
                                }
+                               title             = "Per-host CPU usage"
+                               visualization     = {
+                                   id = "viz.line"
                                }
                            },
+                           {
+                               layout            = {
+                                   column = 6
+                                   height = 3
+                                   row    = 14
+                                   width  = 5
                                }
+                               linkedEntityGuids = null
+                               rawConfiguration  = {
+                                   nrqlQueries = [
+                                       {
+                                           accountIds = [
+                                               3919076,
                                            ]
+                                           query      = "SELECT (average(apm.service.memory.physical) * rate(count(apm.service.instance.count), 1 minute)) / 1000 AS memoryUsage FROM Metric WHERE appName = 'gsa-fac-dev' FACET `host` LIMIT 20 SINCE 7 days ago TIMESERIES"
                                        },
                                    ]
                                }
+                               title             = "Per-host memory usage"
+                               visualization     = {
+                                   id = "viz.line"
                                }
                            },
                        ]
                    },
+                   {
+                       description = null
+                       name        = "Endpoint Details"
+                       widgets     = [
+                           {
+                               layout            = {
+                                   column = 1
+                                   height = 1
+                                   row    = 1
+                                   width  = 10
                                }
+                               linkedEntityGuids = null
+                               rawConfiguration  = {
+                                   text = "# UEI Validation"
                                }
+                               title             = ""
+                               visualization     = {
+                                   id = "viz.markdown"
                                }
                            },
+                           {
+                               layout            = {
+                                   column = 1
+                                   height = 3
+                                   row    = 2
+                                   width  = 2
                                }
+                               linkedEntityGuids = null
+                               rawConfiguration  = {
+                                   nrqlQueries = [
+                                       {
+                                           accountIds = [
+                                               3919076,
                                            ]
+                                           query      = "FROM Transaction SELECT count(*) AS 'Transactions (last hour)' WHERE (appName = 'gsa-fac-dev') AND (request.uri LIKE '/api/sac/ueivalidation%') SINCE 1 hour ago"
                                        },
                                    ]
                                }
+                               title             = "Transactions (last hour)"
+                               visualization     = {
+                                   id = "viz.billboard"
                                }
                            },
+                           {
+                               description       = "Average number of transactions per hour over the past week"
+                               layout            = {
+                                   column = 3
+                                   height = 3
+                                   row    = 2
+                                   width  = 2
                                }
+                               linkedEntityGuids = null
+                               rawConfiguration  = {
+                                   dataFormatters     = [
+                                       {
+                                           name      = "Transactions Per Hour"
+                                           precision = "0"
+                                           type      = "decimal"
                                        },
                                    ]
+                                   linkedEntityGuids  = []
+                                   nrqlQueries        = [
+                                       {
+                                           accountIds = [
+                                               3919076,
                                            ]
+                                           query      = "FROM Transaction SELECT rate(count(*), 1 hour) AS 'Transactions (per hour)' WHERE appName ='gsa-fac-dev' AND request.uri LIKE '/api/sac/ueivalidation%' SINCE 7 days ago"
                                        },
                                    ]
+                                   thresholds         = [
+                                       {
+                                           alertSeverity = "WARNING"
+                                           value         = 5
                                        },
+                                       {
+                                           alertSeverity = "CRITICAL"
+                                           value         = 1
                                        },
                                    ]
+                                   vizcoConfiguration = {
+                                       billboard      = {
+                                           thresholds = [
+                                               {
+                                                   limit = 5
+                                                   type  = "warning"
                                                },
+                                               {
+                                                   limit = 1
+                                                   type  = "critical"
                                                },
                                            ]
                                        }
+                                       dataFormatters = [
+                                           {
+                                               name      = "Transactions Per Hour"
+                                               precision = "0"
+                                               type      = "decimal"
                                            },
                                        ]
                                    }
                                }
+                               title             = "Transactions Target: 1 (per hour/past week)"
+                               visualization     = {
+                                   id = "viz.billboard"
                                }
                            },
+                           {
+                               layout            = {
+                                   column = 5
+                                   height = 3
+                                   row    = 2
+                                   width  = 6
                                }
+                               linkedEntityGuids = null
+                               rawConfiguration  = {
+                                   nrqlQueries = [
+                                       {
+                                           accountId = 3919076
+                                           query     = "FROM Transaction SELECT count(*) AS 'Transactions' WHERE appName = 'gsa-fac-dev' and request.uri LIKE '/api/sac/ueivalidation%' SINCE 14 days ago TIMESERIES"
                                        },
                                    ]
                                }
+                               title             = "Transactions"
+                               visualization     = {
+                                   id = "viz.line"
                                }
                            },
+                           {
+                               layout            = {
+                                   column = 1
+                                   height = 3
+                                   row    = 5
+                                   width  = 2
                                }
+                               linkedEntityGuids = null
+                               rawConfiguration  = {
+                                   nrqlQueries = [
+                                       {
+                                           accountIds = [
+                                               3919076,
                                            ]
+                                           query      = "FROM TransactionError SELECT count(*) AS 'Errors (last hour)' WHERE (appName = 'gsa-fac-dev') AND (request.uri LIKE '/api/sac/ueivalidation%') SINCE 1 hour ago"
                                        },
                                    ]
                                }
+                               title             = "Errors (last hour)"
+                               visualization     = {
+                                   id = "viz.billboard"
                                }
                            },
+                           {
+                               layout            = {
+                                   column = 3
+                                   height = 3
+                                   row    = 5
+                                   width  = 2
                                }
+                               linkedEntityGuids = null
+                               rawConfiguration  = {
+                                   dataFormatters     = [
+                                       {
+                                           name      = "Success Rate (%)"
+                                           precision = "4"
+                                           type      = "decimal"
                                        },
                                    ]
+                                   linkedEntityGuids  = []
+                                   nrqlQueries        = [
+                                       {
+                                           accountIds = [
+                                               3919076,
                                            ]
+                                           query      = "FROM Transaction SELECT 100 - percentage(count(*), WHERE error is true) AS 'Success Rate' WHERE appName ='gsa-fac-dev' AND request.uri LIKE '/api/sac/ueivalidation%' SINCE 7 days ago "
                                        },
                                    ]
+                                   thresholds         = [
+                                       {
+                                           alertSeverity = "WARNING"
+                                           value         = 0.985
                                        },
+                                       {
+                                           alertSeverity = "CRITICAL"
+                                           value         = 0.975
                                        },
                                    ]
+                                   vizcoConfiguration = {
+                                       billboard      = {
+                                           thresholds = [
+                                               {
+                                                   limit = 0.985
+                                                   type  = "warning"
                                                },
+                                               {
+                                                   limit = 0.975
+                                                   type  = "critical"
                                                },
                                            ]
                                        }
+                                       dataFormatters = [
+                                           {
+                                               name      = "Success Rate (%)"
+                                               precision = "4"
+                                               type      = "decimal"
                                            },
                                        ]
                                    }
                                }
+                               title             = "Success Rate Target: Above 97.5%"
+                               visualization     = {
+                                   id = "viz.billboard"
                                }
                            },
+                           {
+                               layout            = {
+                                   column = 5
+                                   height = 3
+                                   row    = 5
+                                   width  = 6
                                }
+                               linkedEntityGuids = null
+                               rawConfiguration  = {
+                                   nrqlQueries = [
+                                       {
+                                           accountId = 3919076
+                                           query     = "FROM TransactionError SELECT count(*) AS 'Errors (last hour)' WHERE (appName = 'gsa-fac-dev') AND (request.uri LIKE '/api/sac/ueivalidation%') SINCE 14 days ago TIMESERIES"
                                        },
                                    ]
                                }
+                               title             = "Errors"
+                               visualization     = {
+                                   id = "viz.line"
                                }
                            },
+                           {
+                               layout            = {
+                                   column = 1
+                                   height = 3
+                                   row    = 8
+                                   width  = 2
                                }
+                               linkedEntityGuids = null
+                               rawConfiguration  = {
+                                   dataFormatters  = [
+                                       {
+                                           name = "p95"
+                                           type = "decimal"
                                        },
+                                       {
+                                           name = "p50"
+                                           type = "decimal"
                                        },
+                                       {
+                                           name = "Average"
+                                           type = "decimal"
                                        },
                                    ]
+                                   facet           = {
+                                       showOtherSeries = false
                                    }
+                                   nrqlQueries     = [
+                                       {
+                                           accountIds = [
+                                               3919076,
                                            ]
+                                           query      = "FROM Transaction SELECT average(convert(duration, 's', 'ms')) AS 'Average', percentile(convert(duration, 's', 'ms'), 50) AS 'p50', percentile(convert(duration, 's', 'ms'), 95) AS 'p95' WHERE (appName = 'gsa-fac-dev') AND (request.uri LIKE '/api/sac/ueivalidation%') SINCE 1 hour ago"
                                        },
                                    ]
+                                   platformOptions = {
+                                       ignoreTimeRange = false
                                    }
                                }
+                               title             = "Latency (last hour)"
+                               visualization     = {
+                                   id = "viz.billboard"
                                }
                            },
+                           {
+                               layout            = {
+                                   column = 3
+                                   height = 3
+                                   row    = 8
+                                   width  = 2
                                }
+                               linkedEntityGuids = null
+                               rawConfiguration  = {
+                                   dataFormatters     = [
+                                       {
+                                           name      = "Average Latency (ms)"
+                                           precision = "0"
+                                           type      = "decimal"
                                        },
                                    ]
+                                   linkedEntityGuids  = []
+                                   nrqlQueries        = [
+                                       {
+                                           accountIds = [
+                                               3919076,
                                            ]
+                                           query      = "FROM Transaction SELECT average(convert(duration, 's', 'ms')) AS 'Average' WHERE (appName = 'gsa-fac-dev') AND (request.uri LIKE '/api/sac/ueivalidation%') SINCE 7 days ago "
                                        },
                                    ]
+                                   thresholds         = [
+                                       {
+                                           alertSeverity = "CRITICAL"
+                                           value         = 1000
                                        },
+                                       {
+                                           alertSeverity = "WARNING"
+                                           value         = 800
                                        },
                                    ]
+                                   vizcoConfiguration = {
+                                       billboard      = {
+                                           thresholds = [
+                                               {
+                                                   limit = 1000
+                                                   type  = "critical"
                                                },
+                                               {
+                                                   limit = 800
+                                                   type  = "warning"
                                                },
                                            ]
                                        }
+                                       dataFormatters = [
+                                           {
+                                               name      = "Average Latency (ms)"
+                                               precision = "0"
+                                               type      = "decimal"
                                            },
                                        ]
                                    }
                                }
+                               title             = "Average Latency Target (last week): 1000ms"
+                               visualization     = {
+                                   id = "viz.billboard"
                                }
                            },
+                           {
+                               layout            = {
+                                   column = 5
+                                   height = 3
+                                   row    = 8
+                                   width  = 6
                                }
+                               linkedEntityGuids = null
+                               rawConfiguration  = {
+                                   facet           = {
+                                       showOtherSeries = false
                                    }
+                                   legend          = {
+                                       enabled = true
                                    }
+                                   nrqlQueries     = [
+                                       {
+                                           accountIds = [
+                                               3919076,
                                            ]
Plan is too large to fit in a PR comment. See the full plan in the workflow log.

📝 Plan generated in Pull Request Checks #4188

@gsa-jrothacker gsa-jrothacker marked this pull request as ready for review January 17, 2025 20:29
Copy link
Contributor

Code Coverage

Package Line Rate Branch Rate Health
. 100% 100%
api 98% 90%
audit 97% 87%
audit.cross_validation 98% 88%
audit.fixtures 84% 50%
audit.intakelib 91% 81%
audit.intakelib.checks 92% 85%
audit.intakelib.common 98% 82%
audit.intakelib.transforms 100% 95%
audit.management.commands 78% 17%
audit.migrations 100% 100%
audit.models 94% 76%
audit.templatetags 100% 100%
audit.views 70% 53%
census_historical_migration 96% 65%
census_historical_migration.migrations 100% 100%
census_historical_migration.sac_general_lib 92% 84%
census_historical_migration.transforms 95% 90%
census_historical_migration.workbooklib 68% 69%
config 76% 31%
curation 100% 100%
curation.curationlib 93% 100%
curation.migrations 100% 100%
dissemination 91% 70%
dissemination.migrations 97% 25%
dissemination.searchlib 76% 66%
dissemination.templatetags 100% 100%
djangooidc 53% 38%
djangooidc.tests 100% 94%
report_submission 93% 88%
report_submission.migrations 100% 100%
report_submission.templatetags 74% 100%
support 91% 66%
support.migrations 100% 100%
support.models 96% 50%
tools 98% 50%
users 95% 92%
users.fixtures 100% 83%
users.management 100% 100%
users.management.commands 100% 100%
users.migrations 100% 100%
Summary 91% (18061 / 19845) 77% (2240 / 2924)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant