Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pandoc #36

Merged
merged 3 commits into from
Sep 11, 2024
Merged

Remove pandoc #36

merged 3 commits into from
Sep 11, 2024

Conversation

rahearn
Copy link
Contributor

@rahearn rahearn commented Sep 11, 2024

🎫 Addresses issue: #34

closes #34

🛠 Summary of changes

  • Remove pandoc from the docker-trestle image (saves ~260mb)
  • Document how to use pandoc/latex image for PDF and HTML generation
  • Update lato/templates/section_7.md to remove unicode characters that don't work out-of-the-box with pandoc/latex

@rahearn rahearn requested a review from a team September 11, 2024 12:53
Copy link
Contributor

@zjrgov zjrgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saving the 260mb definitely seems like a positive tradeoff--especially with the docs pointing out those are just two possible formats of many.

Comment on lines +1 to +3
{% macro system_status(state_value, display_text) -%}
{{"**" if ssp.system_characteristics.status.state.value == state_value}}{{display_text}}{{"**" if ssp.system_characteristics.status.state.value == state_value}}
{%- endmacro %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oo fancy templates

@rahearn rahearn merged commit 9e3ccd1 into main Sep 11, 2024
1 check passed
@rahearn rahearn deleted the remove-pandoc branch September 11, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use public pandoc images for pandoc commands, rather than installing in our image
2 participants