Linting baseline and initial Circle/CI integration

[jadudm]

We prefer smaller PRs that merge more often.

Haiku-length summary

Amidst drifting snow
So much lint like water flows
Once, and future, fluff

Additional details

linting

This introduces golangci-lint, and integrates it into the stack. This can (currently) be triggered locally either via make lint (if the tools are installed locally), or make containerlint to run in a containerized environment.

Hundreds of linting errors were addressed. Some were flagged as nolint on a per-file basis (e.g. linting involving naming of test packages, or some documentation linting), some were flagged per-line, and some were put in the ignore list.

The linting that was flagged/ignored will need to be addressed as debt. This provides us an initial baseline where the code passes a rigorous set of linting, and makes clear where we want to do some fixes (the ignores/nolint lines).

Circle/CI

We cannot use Github Actions. We can use Circle/CI. This introduces a basic C/CI config. It allows us to

1. Lint, and
2. Build

The configuration successfully lints in the cloud, and only goes on to build the application if the linting passes.

related tickets

This work is in partial fulfillment of:

• stateless (terraform) deployments to cloud.gov #55
• static code analysis/scanning #67
• ATO checklist #65

PR Checklist: Submitter

• Link to an issue if possible. If there’s no issue, describe what your branch does. Even if there is an issue, a brief description in the PR is still useful.
• List any special steps reviewers have to follow to test the PR. For example, adding a local environment variable, creating a local test file, etc.
• For extra credit, submit a screen recording like this one.
• Make sure you’ve merged main into your branch shortly before creating the PR. (You should also be merging main into your branch regularly during development.)
• Make sure that whatever feature you’re adding has tests that cover the feature. This includes test coverage to make sure that the previous workflow still works, if applicable.
• Make sure the E2E tests pass.
• Do manual testing locally.
  • If that’s not applicable for some reason, check this box.
• Once a PR is merged, keep an eye on it until it’s deployed to dev, and do enough testing on dev to verify that it deployed successfully, the feature works as expected, and the happy path for the broad feature area still works.

PR Checklist: Reviewer

• Pull the branch to your local environment and run make macup ; make e2e" (FIXME)
• Manually test out the changes locally
  • Check this box if not applicable in this case.
• Check that the PR has appropriate tests.

The larger the PR, the stricter we should be about these points.

[IsabelLaurenceau]

After docker desktop update containers run correctly, and I am able to run make containerlint as expected

The merge-base changed after approval.

[jadudm]

Superceded by #88. Closing this.