Refactors shift tooltips on MetaBaseItem a bit #3333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FourIsTheNumber
added
refactor
RecursivePineapple
approved these changes
Oct 16, 2024
|
@querns @RecursivePineapple can this resolved ? @Alexdoru |
# Conflicts: # src/main/java/gregtech/common/items/behaviors/BehaviourSprayColorInfinite.java
auto-merge was automatically disabled
October 16, 2024 19:06
Head branch was pushed to by a user without write access
|
should be fixed now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I added the ability to create a separate tooltip on
MetaBaseItems by holding Shift, it caused a little bit of undesirable behavior. Regular items, like the wrench or data stick, were having some of their normal tooltips be clobbered by a too-eager shift tooltip invocation. I've refactored the way tooltips are applied fromIItemBehaviors a bit to make it not do that. NowMetaBaseItems with no shift-tooltip defined won't clobber part of their normal tooltip.