-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor ore and worldgen #3662
base: master
Are you sure you want to change the base?
Conversation
Changing to use dimension name will probably break FE's multiworld since you can name a dimension. This would effectively defeat the purpose of not using hardcoded dims since you would not be able to create a multiworld with GT ores in it again... |
@spacebuilder2020 I've never used forge essentials, but it looks like it'll be fine as long as the multiworld uses the proper provider. It determines what ores to generate based on the provider's dimension name, so if you make a multiworld with the nether provider it'll generate everything normally. |
ok, I thought it was based on the world name. If it is the provider dim name then it is probably fine, but I want to know what your reasoning for changing it to the name? |
That is true, though it was already doing that with the provider class instance. I did leave the old methods in for the ids but mostly because I didn't want to refactor the other mods at the time. With that said, and given the issues we had with using instance of, provider name is probably the best since an extended provider like RWG will probably not override the dimension name and an extended one like twilight will. |
I'll start saving profiles for every dimension (I've been profiling it, but I haven't been keeping them). In every dimension that I've profiled oregen time is basically zero. The nether: https://spark.lucko.me/m6S8EDfm1t The worldgen call for the nether is all over the place so it's hard to get an accurate measurement, but it's still very small regardless. |
End asteroids: |
These are incompatible with NEID and can cause problems with blocks whose metadata can go over 127.
Summary:
Todo:
Changes: