Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change QFT hatch requirements #3813

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Change QFT hatch requirements #3813

wants to merge 5 commits into from

Conversation

Nockyx
Copy link
Contributor

@Nockyx Nockyx commented Jan 14, 2025

QFT has some specific hatch requirements that always confuse people on how to insert the special plasmas for focusing. And also limits the construction of the multiblock.
image

This PR removes the specificity of hatches on the sides of the controller to be on any bottom casing.

@Nockyx Nockyx added the enhancement Improve an existing mechanic. Please explain the change with a before/after comparison. label Jan 14, 2025
@Dream-Master Dream-Master requested a review from a team January 14, 2025 21:27
@Nockyx
Copy link
Contributor Author

Nockyx commented Jan 14, 2025

Took the opportunity to also include a changing in the way the multiblock behaves when the plasma runs out.

Currently, whenever the multiblock runs out of plasma it will crash to avoid producing extra materials without consuming plasma.
This can lead to situations where a plasma can run out for a brief moment and leave the multiblock crashed for hours.

The commit change so whenever it runs out of plasma, the recipe will be voided and skipped instantly, starting a new cycle without bonuses.

Comment on lines -295 to +226
+ "Left"
+ "Bottom"
+ EnumChatFormatting.GRAY
+ " side of Controller")
+ " Layer")
.addStructureInfo(
EnumChatFormatting.WHITE + "Fermium Plasma Hatch: "
+ EnumChatFormatting.DARK_GREEN
+ "Right"
+ "Bottom"
+ EnumChatFormatting.GRAY
+ " side of Controller")
+ " Layer")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think these need to be separately specified at all anymore, since they are treated as normal input hatches which are also just anywhere in bottom layer

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right! I'll take care of that.

@Dream-Master Dream-Master added the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta enhancement Improve an existing mechanic. Please explain the change with a before/after comparison.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants