Skip to content

Commit

Permalink
Revert some comments about collecting area to match the current code.
Browse files Browse the repository at this point in the history
  • Loading branch information
rmjarvis committed Oct 12, 2023
1 parent 420d594 commit 39a878c
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 4 deletions.
2 changes: 0 additions & 2 deletions galsim/roman/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@

gain = 1.0
pixel_scale = 0.11 # arcsec / pixel
# Effective area now taken into account in the bandpass throughput (units of effective area, m^2) and sky background files.
# To modify these assumptions, remove approximate factor of eff_area = 0.25 * np.pi * diameter**2 * (1. - obscuration**2) in meters^2 and rescale to new values of these parameters.
diameter = 2.36 # meters
obscuration = 0.32
collecting_area = 3.757e4 # cm^2, from Cycle 7
Expand Down
14 changes: 12 additions & 2 deletions galsim/roman/roman_bandpass.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,18 @@ def getBandpasses(AB_zeropoint=True, default_thin_trunc=True, **kwargs):
if thinning is not desired, truncation is recommended.
By default, the routine will set an AB zeropoint (unless ``AB_zeropoint=False``). The
zeropoint in this module is defined such that the flux is 1 photon/sec through the
bandpass.
zeropoint in GalSim is defined such that the flux is 1 photon/cm^2/sec through the
bandpass. This differs from an instrumental bandpass, which is typically defined such that the
flux is 1 photon/sec for that instrument. The difference between the two can be calculated as
follows::
# Shift zeropoint based on effective collecting area in cm^2.
delta_zp = 2.5 * np.log10(galsim.roman.collecting_area)
``delta_zp`` will be a positive number that should be added to the GalSim zeropoints to compare
with externally calculated instrumental zeropoints. When using the GalSim zeropoints for
normalization of fluxes, the ``area`` kwarg to drawImage can be used to get the right
normalization (giving it the quantity ``galsim.roman.collecting_area``).
This routine also loads information about sky backgrounds in each filter, to be used by the
galsim.roman.getSkyLevel() routine. The sky background information is saved as an attribute in
Expand Down

0 comments on commit 39a878c

Please sign in to comment.