Skip to content

Commit

Permalink
Fixes for test and changelog
Browse files Browse the repository at this point in the history
  • Loading branch information
sebastiandro committed Jan 26, 2024
1 parent 399c3f3 commit 3bb96f4
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 8 deletions.
6 changes: 3 additions & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@

## [Unreleased]

## [0.12.0] - 2023-12-19

### Fixed

- :bug: Add support for dataset factories in KedroPipelineML ([#516, rxm7706](https://github.com/Galileo-Galilei/kedro-mlflow/pull/519))
- :bug: Add support for dataset factories in KedroPipelineML ([#516, sebastiandro](https://github.com/Galileo-Galilei/kedro-mlflow/pull/519))

## [0.12.0] - 2023-12-19

### Added

Expand Down
6 changes: 1 addition & 5 deletions tests/framework/hooks/test_hook_pipeline_ml.py
Original file line number Diff line number Diff line change
Expand Up @@ -631,17 +631,12 @@ def test_mlflow_hook_save_pipeline_ml_with_artifact_path(
assert trained_model is not None


@pytest.mark.parametrize(
"namespace",
(["a", "b"]),
)
def test_mlflow_hook_save_pipeline_ml_with_dataset_factory(
kedro_project_with_mlflow_conf,
env_from_dict,
dummy_pipeline_dataset_factory,
dummy_catalog_dataset_factory,
dummy_run_params,
namespace,
):
"""
Test for PipelineML factory where the input catalog has data factories.
Expand All @@ -657,6 +652,7 @@ def test_mlflow_hook_save_pipeline_ml_with_dataset_factory(
"conda_env": env_from_dict,
}

namespace = "a"
log_model_kwargs["artifact_path"] = "artifacts"
dummy_pipeline_with_namespace = pipeline(
pipe=dummy_pipeline_dataset_factory, namespace=namespace
Expand Down

0 comments on commit 3bb96f4

Please sign in to comment.