Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to kedro 19 #502

Merged
merged 12 commits into from
Dec 19, 2023
Merged

Upgrade to kedro 19 #502

merged 12 commits into from
Dec 19, 2023

Conversation

Galileo-Galilei
Copy link
Owner

@Galileo-Galilei Galileo-Galilei commented Dec 19, 2023

Description

Close #391 #480

Development notes

  • Officially drop supports for 0.18.x and add supports for 0.19.x
  • Final cleanup before migration to kedro==0.19 and dropping kedro==0.18 support. Mostly fixing tests:
    • Remove package_name argument in KedroSession.create calls
    • Add replace project_version by kedro_init_version key in pyproject.toml
    • Use kwargs when instantiating datasets since they are now kwargs only.
  • Remove exception catching when retrieving configuration  #480 : Revert error catching hack for done in # specifically for kedro==0.18.1 compatibility
  • Partially revert Test_frozen_context #489 which introduced a "forced type casting" when the dataset was specified as an object instead of a string. This was done because of a bug introduced by kedro and fixed last week in : Bug fix for parse dataest definition kedro-org/kedro#3400
  • Fix MlflowAbstractModelDataset which was incorrectly named MlflowModelRegistryDataset due to a bad copy /paste
  • Upgrade issue templates to avoid polluting issues with advices on how to fill them

Checklist

  • Read the contributing guidelines
  • Open this PR as a 'Draft Pull Request' if it is work-in-progress
  • Update the documentation to reflect the code changes
  • Add a description of this change and add your name to the list of supporting contributions in the CHANGELOG.md file. Please respect Keep a Changelog guidelines.
  • Add tests to cover your changes

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

  • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (93b3c9f) 99.89% compared to head (5cb9e6c) 99.89%.
Report is 12 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #502   +/-   ##
=======================================
  Coverage   99.89%   99.89%           
=======================================
  Files          28       28           
  Lines         982      998   +16     
=======================================
+ Hits          981      997   +16     
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Galileo-Galilei added a commit that referenced this pull request Dec 19, 2023
Galileo-Galilei added a commit that referenced this pull request Dec 19, 2023
@Galileo-Galilei Galileo-Galilei marked this pull request as ready for review December 19, 2023 13:26
Signed-off-by: Yolan Honoré-Rougé <yolan.honore.rouge@gmail.com>
Signed-off-by: Yolan Honoré-Rougé <yolan.honore.rouge@gmail.com>
…args only datasets instantiation (#502)

Signed-off-by: Yolan Honoré-Rougé <yolan.honore.rouge@gmail.com>
Signed-off-by: Yolan Honoré-Rougé <yolan.honore.rouge@gmail.com>
…ompatibility (#480)

Signed-off-by: Yolan Honoré-Rougé <yolan.honore.rouge@gmail.com>
… when configuration was not a string (#502)

Signed-off-by: Yolan Honoré-Rougé <yolan.honore.rouge@gmail.com>
Signed-off-by: Yolan Honoré-Rougé <yolan.honore.rouge@gmail.com>
…elRegistryDataset (#502)

Signed-off-by: Yolan Honoré-Rougé <yolan.honore.rouge@gmail.com>
Signed-off-by: Yolan Honoré-Rougé <yolan.honore.rouge@gmail.com>
…w to fill them (#502)

Signed-off-by: Yolan Honoré-Rougé <yolan.honore.rouge@gmail.com>
Signed-off-by: Yolan Honoré-Rougé <yolan.honore.rouge@gmail.com>
Signed-off-by: Yolan Honoré-Rougé <yolan.honore.rouge@gmail.com>
@Galileo-Galilei Galileo-Galilei merged commit cf64533 into master Dec 19, 2023
16 of 17 checks passed
@Galileo-Galilei Galileo-Galilei deleted the upgrade-to-kedro-19 branch December 19, 2023 13:45
Galileo-Galilei added a commit that referenced this pull request Dec 19, 2023
…args only datasets instantiation (#502)

Signed-off-by: Yolan Honoré-Rougé <yolan.honore.rouge@gmail.com>
Galileo-Galilei added a commit that referenced this pull request Dec 19, 2023
… when configuration was not a string (#502)

Signed-off-by: Yolan Honoré-Rougé <yolan.honore.rouge@gmail.com>
Galileo-Galilei added a commit that referenced this pull request Dec 19, 2023
Signed-off-by: Yolan Honoré-Rougé <yolan.honore.rouge@gmail.com>
Galileo-Galilei added a commit that referenced this pull request Dec 19, 2023
…elRegistryDataset (#502)

Signed-off-by: Yolan Honoré-Rougé <yolan.honore.rouge@gmail.com>
Galileo-Galilei added a commit that referenced this pull request Dec 19, 2023
…w to fill them (#502)

Signed-off-by: Yolan Honoré-Rougé <yolan.honore.rouge@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup for kedro==0.19
2 participants