Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make project level cli work inside subdirectory (#531) #539

Merged
merged 5 commits into from
Apr 17, 2024

Conversation

Galileo-Galilei
Copy link
Owner

Description

  • Fix a bug which prevents importng the CLi with kedro==0.19.4 because I relied on private _is_project.
  • On the way, make all project level CLI (init, ui, and modelify) work inside a subdirectory and not only at the root of kedro level

Development notes

  • Create my own _is_project and _find_kedro_project functions which manges the import of the private functions of kedro.
  • Change all CLI to get the project path with _find_kedro_project instead of taking Path.cwd.

Checklist

  • Read the contributing guidelines
  • Open this PR as a 'Draft Pull Request' if it is work-in-progress
  • N/A Update the documentation to reflect the code changes
  • Add a description of this change and add your name to the list of supporting contributions in the CHANGELOG.md file. Please respect Keep a Changelog guidelines.
  • Add tests to cover your changes

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

  • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.90%. Comparing base (70a9002) to head (b164a34).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #539   +/-   ##
=======================================
  Coverage   99.90%   99.90%           
=======================================
  Files          29       29           
  Lines        1008     1021   +13     
=======================================
+ Hits         1007     1020   +13     
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Galileo-Galilei Galileo-Galilei merged commit bda15bb into master Apr 17, 2024
14 of 16 checks passed
@Galileo-Galilei Galileo-Galilei deleted the 531-fix-inside-directory branch April 17, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants