Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Replace get_all_metrics in MLflowMetricsHistoryDataset to be compatible with all Mlflow stores (#582) #591

Merged
merged 3 commits into from
Sep 24, 2024

Conversation

Galileo-Galilei
Copy link
Owner

@Galileo-Galilei Galileo-Galilei commented Sep 22, 2024

Description

Close #582

Development notes

What have you changed, and how has this been tested?

Checklist

  • Read the contributing guidelines
  • Open this PR as a 'Draft Pull Request' if it is work-in-progress
  • Update the documentation to reflect the code changes
  • Add a description of this change and add your name to the list of supporting contributions in the CHANGELOG.md file. Please respect Keep a Changelog guidelines.
  • Add tests to cover your changes

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

  • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

@Galileo-Galilei Galileo-Galilei changed the title 🐛 Replace get_all_metrics in MLflowMetricsHistoryDataset to be comaptible with all Mlflow stores (#582) 🐛 Replace get_all_metrics in MLflowMetricsHistoryDataset to be compatible with all Mlflow stores (#582) Sep 22, 2024
@Galileo-Galilei Galileo-Galilei force-pushed the 582-metrics_history-dataset-to-server branch from a2a3507 to fc377a9 Compare September 22, 2024 21:12
@Galileo-Galilei Galileo-Galilei force-pushed the 582-metrics_history-dataset-to-server branch from fc7b5cd to 996d4b9 Compare September 23, 2024 21:05
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f066d7d) to head (996d4b9).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #591   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           29        29           
  Lines         1032      1026    -6     
=========================================
- Hits          1032      1026    -6     
Flag Coverage Δ
100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Galileo-Galilei Galileo-Galilei marked this pull request as ready for review September 23, 2024 21:16
@Galileo-Galilei Galileo-Galilei merged commit 089e7aa into master Sep 24, 2024
16 of 17 checks passed
@Galileo-Galilei Galileo-Galilei deleted the 582-metrics_history-dataset-to-server branch September 24, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't publish MlflowMetricsHistoryDataset to Remote tracking server
2 participants