Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement missing PipelineML slicing functionalities #601

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Calychas
Copy link

Description

Implements the rest of PipelineML slicing functionalities.

Development notes

Currently, when something fails while running a pipeline, kedro tries to provide a hint command to resume. However, as PipelineML doesn't implement them all, it throws an additional error while trying to provide a hint. This results in messy logging on the actual error (you need to scroll up to see what actually broke), and oftentimes one can mistakenly think that something went wrong during packaging of the model.

This PR tries to fix this problem.

Checklist

  • Read the contributing guidelines
  • Open this PR as a 'Draft Pull Request' if it is work-in-progress
  • Update the documentation to reflect the code changes
  • Add a description of this change and add your name to the list of supporting contributions in the CHANGELOG.md file. Please respect Keep a Changelog guidelines.
  • Add tests to cover your changes

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

  • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

@Galileo-Galilei
Copy link
Owner

Galileo-Galilei commented Oct 17, 2024

Definitely fine with that, this would be a partial solution to #377.

Can you just update the corresponding test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants