Merge pull request #157 from GaloyMoney/chore--no-longer-treat-dealer…

…-error-as-critical-as-it's-now-been-deprecated chore: no longer treat dealer error as critical as it's now been deprecated
GaloyMoney · Feb 5, 2023 · 5138c7f · 5138c7f
2 parents 12cf21d + 3aa8855
commit 5138c7f
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 12 deletions.
diff --git a/dealer/src/DealerRemoteWalletV2.ts b/dealer/src/DealerRemoteWalletV2.ts
@@ -150,7 +150,7 @@ export class DealerRemoteWalletV2 implements GaloyWallet {
             },
           }
         } catch (error) {
-          recordExceptionInCurrentSpan({ error, level: ErrorLevel.Critical })
+          recordExceptionInCurrentSpan({ error, level: ErrorLevel.Info })
           logger.error(
             { query: BALANCE_QUERY, error },
             "{query} to galoy graphql api failed with {error}",
@@ -336,7 +336,7 @@ export class DealerRemoteWalletV2 implements GaloyWallet {
 
           return { ok: true, value: undefined }
         } catch (error) {
-          recordExceptionInCurrentSpan({ error, level: ErrorLevel.Critical })
+          recordExceptionInCurrentSpan({ error, level: ErrorLevel.Info })
           logger.error(
             { mutation: MUTATIONS.onChainAddressCurrent, error },
             "{mutation} to galoy graphql api failed with {error}",

diff --git a/dealer/src/ExchangeBase.ts b/dealer/src/ExchangeBase.ts
@@ -122,7 +122,7 @@ export abstract class ExchangeBase {
             value: result,
           }
         } catch (error) {
-          recordExceptionInCurrentSpan({ error, level: ErrorLevel.Critical })
+          recordExceptionInCurrentSpan({ error, level: ErrorLevel.Info })
           return { ok: false, error: error }
         }
       },
@@ -303,7 +303,7 @@ export abstract class ExchangeBase {
             },
           }
         } catch (error) {
-          recordExceptionInCurrentSpan({ error, level: ErrorLevel.Critical })
+          recordExceptionInCurrentSpan({ error, level: ErrorLevel.Info })
           return { ok: false, error: error }
         }
       },
@@ -448,7 +448,7 @@ export abstract class ExchangeBase {
             },
           }
         } catch (error) {
-          recordExceptionInCurrentSpan({ error, level: ErrorLevel.Critical })
+          recordExceptionInCurrentSpan({ error, level: ErrorLevel.Info })
           return { ok: false, error: error }
         }
       },
@@ -493,7 +493,7 @@ export abstract class ExchangeBase {
             },
           }
         } catch (error) {
-          recordExceptionInCurrentSpan({ error, level: ErrorLevel.Critical })
+          recordExceptionInCurrentSpan({ error, level: ErrorLevel.Info })
           return { ok: false, error: error }
         }
       },
@@ -566,7 +566,7 @@ export abstract class ExchangeBase {
             value: result,
           }
         } catch (error) {
-          recordExceptionInCurrentSpan({ error, level: ErrorLevel.Critical })
+          recordExceptionInCurrentSpan({ error, level: ErrorLevel.Info })
           return { ok: false, error: error }
         }
       },

diff --git a/dealer/src/OkexExchange.ts b/dealer/src/OkexExchange.ts
@@ -182,7 +182,7 @@ export class OkexExchange extends ExchangeBase {
             value: true,
           }
         } catch (error) {
-          recordExceptionInCurrentSpan({ error, level: ErrorLevel.Critical })
+          recordExceptionInCurrentSpan({ error, level: ErrorLevel.Info })
           return { ok: true, value: true }
         }
       },

diff --git a/dealer/src/services/tracing.ts b/dealer/src/services/tracing.ts
@@ -153,7 +153,7 @@ export const syncRunInSpan = <F extends () => ReturnType<F>>(
       span.end()
       return ret
     } catch (error) {
-      recordException(span, error, ErrorLevel.Critical)
+      recordException(span, error, ErrorLevel.Info)
       span.end()
       throw error
     }
@@ -175,7 +175,7 @@ export const asyncRunInSpan = <F extends () => ReturnType<F>>(
       span.end()
       return ret
     } catch (error) {
-      recordException(span, error, ErrorLevel.Critical)
+      recordException(span, error, ErrorLevel.Info)
       span.end()
       throw error
     }
@@ -252,7 +252,7 @@ export const wrapToRunInSpan = <
         span.end()
         return ret
       } catch (error) {
-        recordException(span, error, ErrorLevel.Critical)
+        recordException(span, error, ErrorLevel.Info)
         span.end()
         throw error
       }
@@ -299,7 +299,7 @@ export const wrapAsyncToRunInSpan = <
         span.end()
         return ret
       } catch (error) {
-        recordException(span, error, ErrorLevel.Critical)
+        recordException(span, error, ErrorLevel.Info)
         span.end()
         throw error
       }